Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Kerberos Support via Command Line Switches #1331

Merged
merged 4 commits into from Apr 12, 2019
Merged

Conversation

@frumania
Copy link
Contributor

@frumania frumania commented Mar 8, 2019

Description

I have developed a recipe for an application called QUIP, that, in our company, requires Kerberos authentication => certain chrome policies have to be set e.g.
--auth-server-whitelist *.mydomain.com
--auth-negotiate-delegate-whitelist *.mydomain.com
see also here or via chrome://policy/

Motivation and Context

Allows to pass the desired command line parameters (https://electronjs.org/docs/api/chrome-command-line-switches) directly to Chromium inside Electron, to enable Kerberos support. I originally thought to add this to the settings screen, but i came up with this simple approach.

How Has This Been Tested?

Ran my recipe against our corporate QUIP, authentication works successfully.
Usage e.g. on MACOS
$ Franz.app/Contents/MacOS/Franz --auth-server-whitelist *.mydomain.com --auth-negotiate-delegate-whitelist *.mydomain.com

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [ X ] My code follows the code style of this project (run $ yarn lint).

Doc could be updated, moving forward

@adlk adlk changed the base branch from master to develop Apr 12, 2019
@adlk
Copy link
Contributor

@adlk adlk commented Apr 12, 2019

This screams for a support article 😉

Anyhow, thanks for adding this :shipit:

Loading

@adlk adlk merged commit a1950d7 into meetfranz:develop Apr 12, 2019
2 checks passed
Loading
@bocekm
Copy link

@bocekm bocekm commented Sep 4, 2020

How can I pass the params to the flatpak version on Fedora? Running flatpak run com.meetfranz.Franz --auth-server-whitelist *.mydomain.com --auth-negotiate-delegate-whitelist *.mydomain.com causes the app to crash.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants