Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate gcloud coupling #117

Merged
merged 5 commits into from Sep 11, 2019

Conversation

@chenrui333
Copy link
Member

commented Sep 6, 2019

GAE usage seems pretty limited so deprecating serviceId (which is ref to gaeModuleId)
GCS dependency has been deprecated in #113

@chenrui333 chenrui333 requested review from sergeychernyshev and mmcgahan Sep 6, 2019

@chenrui333 chenrui333 changed the title Remove serviceId as S3 bucket is different btw pro-web and mup-web Deprecate gcloud coupling Sep 6, 2019

@chenrui333 chenrui333 added the wip label Sep 6, 2019

@chenrui333

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2019

@chenrui333 chenrui333 removed the wip label Sep 6, 2019

@mmcgahan
Copy link
Collaborator

left a comment

Great!

@sadafie

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Should we consider this a major version bump? There might be a Makefile that needs updating if so.

@chenrui333

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

yeah, we should have major version bump. I will do that shortly.

@chenrui333 chenrui333 merged commit 31ba85b into master Sep 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@delete-merged-branch delete-merged-branch bot deleted the remove-gcloud-infra branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.