Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Informer send notification after closed #88

Closed
localvar opened this issue Jun 29, 2021 · 0 comments
Closed

Informer send notification after closed #88

localvar opened this issue Jun 29, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@localvar
Copy link
Collaborator

As discussed in #79 (comment), it is possible for the current mesh informer implementation to send notifications after it is closed, this is unexpected and may cause bugs.

To fix this, we can add a wait operation in informer.Close to ensure all notifications are sent before the function returns, the change itself is simple but we need to check the existing code to ensure the wait does not cause a deadlock.

If the above solution is not possible, we can document the behavior and let client code handle the delayed notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants