Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nacosserviceregistry.go #478

Merged
merged 2 commits into from Jan 25, 2022

Conversation

jthann
Copy link
Collaborator

@jthann jthann commented Jan 25, 2022

fix nacos sservice registry for deadloop bug. https://github.com/megaease/easegress/issues/477

@samutamm
Copy link
Contributor

@jthann I think the indentation might be broken.. Could you please run make fmt command locally and commit the changes. ^^

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2022

Codecov Report

Merging #478 (be820c5) into main (76f8f86) will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   80.11%   80.25%   +0.13%     
==========================================
  Files          83       83              
  Lines        9631     9676      +45     
==========================================
+ Hits         7716     7765      +49     
+ Misses       1469     1468       -1     
+ Partials      446      443       -3     
Impacted Files Coverage Δ
pkg/filter/headertojson/headertojson.go 72.54% <0.00%> (-7.46%) ⬇️
pkg/object/mqttproxy/client.go 79.63% <0.00%> (-0.91%) ⬇️
pkg/object/meshcontroller/spec/spec.go 87.07% <0.00%> (-0.13%) ⬇️
pkg/cluster/cluster.go 52.89% <0.00%> (+1.02%) ⬆️
pkg/filter/validator/basicauth.go 78.89% <0.00%> (+8.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f8f86...be820c5. Read the comment docs.

@jthann
Copy link
Collaborator Author

jthann commented Jan 25, 2022

@jthann I think the indentation might be broken.. Could you please run make fmt command locally and commit the changes. ^^

fixed and commit again

@xxx7xxxx xxx7xxxx merged commit 60e7d83 into easegress-io:main Jan 25, 2022
@jthann jthann deleted the fix-nacos-deadloop-bug branch January 27, 2022 04:59
@jthann jthann restored the fix-nacos-deadloop-bug branch January 27, 2022 04:59
@jthann jthann deleted the fix-nacos-deadloop-bug branch January 27, 2022 04:59
samutamm pushed a commit to samutamm/easegress that referenced this pull request Jan 27, 2022
* Update nacosserviceregistry.go

* Update nacosserviceregistry.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants