Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added threading support #204

Merged
merged 1 commit into from Apr 3, 2020
Merged

Added threading support #204

merged 1 commit into from Apr 3, 2020

Conversation

mlimber
Copy link
Contributor

@mlimber mlimber commented Apr 3, 2020

Fulfilling issue described in issue 203.

@megastep
Copy link
Owner

megastep commented Apr 3, 2020

This is interesting, but my main concern is specifying these threads arguments to commands that will then be invoked by the archive. It seems to me that it would make such archives more prone to fail to extract on systems where the xz command for instance isn't compiled with threading support.

@megastep
Copy link
Owner

megastep commented Apr 3, 2020

Also the benefits of these I would think are fairly minimal for most systems, and would only have a small performance improvement for massive archives (where I/O tends to be a bigger bottleneck anyway). So I'm not convinced potentially breaking the universality of archives is a good trade-off.

@megastep
Copy link
Owner

megastep commented Apr 3, 2020

Nevermind, looks like I misread the code and was thinking of decompression more than compression 😅

@megastep megastep merged commit 1a7638d into megastep:master Apr 3, 2020
@mlimber
Copy link
Contributor Author

mlimber commented Apr 6, 2020

Thanks. I upped the version number to 2.4.2. Do you want to create a release tag for it? (Note: the version log at the top of the main .sh file didn't have an entry for 2.4.1.)

@megastep
Copy link
Owner

megastep commented Apr 6, 2020

Probably soon. There's a few other issues that might warrant another look first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants