Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
add basic Projection (definition) support for Map #82
This PR provides basic support to use other projections than the default Web Mercator. It has the following changes:
Was new to Wegue, so hope the changes are at the proper places. Hope that is the intention, at least within NL most apps use our local projection. I realize that introducing projections also introduces complexity, don't know if that is the intention for Wegue.
Thanks for the good work! Hopefully Wegue can be a follow-up for GeoExt!
chrismayer left a comment
Thanks a lot for your contribution @justb4 ! This is very cool. I did this (using custom projection) mostly on project / application level. But I like the idea introducing this into Wegue. Since it is a common use case.
Could you please correct the attribution before I merge this, so the map credits are shown correctly (see comment in code)? I also had some other minor remarks, which you might want to address at will (non blocking for merging this)
Thanks for the feedback and the nice words. Some background information what is happening at the moment.:
Still a long way to go
I hope Wegue will get more contributors (user, tester, coder, ...) so I am very happy you came up with this PR. Thank you very much for you work!
Thanks for feedback, all changes made, you may squash-merge.
Good to see/hear about your activities in your local fork! Was not aware. Still doing Heron (GeoExt v1, Ext3, OL 2.12!) maintenance, but with other Heron devs I was looking for a new mapping framework. Skipping NG altogether, I dabbled with ReactJS but am really happy with Vue.js, especially after the big Vue.js conf in Amsterdam. Though most new frameworks (MapStore2, Boundless SDK, GeoMoose) use React...
So, also as Heron is largely a configuration convention using ExtJS
But anyway will start with small steps, can't promise ample time as working in several FOSS projects.
Me as well, I was convinced very quickly by the lightweight approach, not having a too big buy in.
Cool, very appreciated!
Good point! Let's discuss in #83
Thanks for your ongoing work on this @justb4!