Skip to content

Meg Sharkey megshark

  • Metamarkets
  • San Francisco, CA
  • Joined on Aug 10, 2011
megshark commented on pull request sdepold/sequelize#84
Meg Sharkey

Yeah, I think it just needed doc... Sent from my iPhone On Nov 4, 2012, at 11:48 AM, Sascha Depold notifications@github.com wrote: guess we can cl…

megshark commented on pull request sdepold/sequelize#84
Meg Sharkey

Are people +1 on this for documentation? Because there is nothing code-wise to fix here that I know about....

megshark opened pull request sdepold/sequelize#211
Meg Sharkey
Add pooling support for postgres
2 commits with 22 additions and 7 deletions
Meg Sharkey
  • Meg Sharkey d9781b3
    specify pooling param for tests
Meg Sharkey
megshark commented on pull request sdepold/sequelize#146
Meg Sharkey

Right, although that still wouldn't support the mysql case because their client doesn't support pooling, which was the motivation for this feature …

megshark commented on pull request sdepold/sequelize#146
Meg Sharkey

OK, I should be on the IRC now…. I should be able to do the easy configuration thing for postgres sometime next week if that sounds OK. If you want…

megshark commented on pull request sdepold/sequelize#146
Meg Sharkey

Hi there! I actually started down that path, but then while looking at the code for the postgres node module I noticed that it had it's own built-i…

megshark commented on pull request ajaxorg/ace#665
Meg Sharkey

OK, signed the CLA & emailed. Still have worker on my TO-DO list!

megshark commented on pull request sdepold/sequelize#146
Meg Sharkey

So, the tests "hanging" was just the maxIdleTime for the pool being set to 30 seconds. If you waited around that long, it would actually exit. I ch…

Meg Sharkey
  • Meg Sharkey 9f8900f
    fixed tests not exiting -- make pool maxIdleTime small
Meg Sharkey
megshark commented on pull request sdepold/sequelize#146
Meg Sharkey

Sorry, I've been sick! Will try to get to this soon! Sent from my iPhone On Apr 23, 2012, at 9:37 PM, Sascha Depoldreply@reply.github.com wrote: a…

megshark commented on pull request sdepold/sequelize#146
Meg Sharkey

Sounds good… sorry, just seeing this now. -Meg On Apr 17, 2012, at 9:19 PM, Sascha Depold wrote: @@ -11,13 +12,33 @@ module.exports = (function() {…

Meg Sharkey
Meg Sharkey
  • Meg Sharkey f634ae4
    make mock Express response to mimic express shortcuts
megshark commented on pull request sdepold/sequelize#146
Meg Sharkey

I thought it was OK. I'm always kind of self-critical. :) What do you think now that you've had a chance to look it over. It works, it's configurab…

Something went wrong with that request. Please try again.