Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run clippy only on MSRV #362

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Conversation

matthiasbeyer
Copy link
Collaborator

@matthiasbeyer matthiasbeyer commented Aug 2, 2022

This patch reverts the matrix for the clippy job to only run clippy on
our MSRV instead of stable, beta and nightly.

The recurring issue with this was that lints started failing in PRs that
couldn't have been fixed in master yet, because master was never tested
with a clippy that new (in case of nightly).

1.56.1 is good enough for now.


Closes #361

This patch reverts the matrix for the clippy job to only run clippy on
our MSRV instead of stable, beta and nightly.

The recurring issue with this was that lints started failing in PRs that
couldn't have been fixed in master yet, because master was never tested
with a clippy that new (in case of nightly).

1.56.1 is good enough for now.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
I am not sure what happened that these tests suddenly fail, or where the
artifact comes from...

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Copy link
Collaborator Author

#361 was included here now.

@matthiasbeyer matthiasbeyer merged commit ab556a9 into mehcode:master Aug 2, 2022
@matthiasbeyer matthiasbeyer deleted the clippy-on-msrv branch August 2, 2022 07:24
matthiasbeyer added a commit that referenced this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant