Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13.x: Backport #362 #364

Conversation

matthiasbeyer
Copy link
Collaborator

Port #362 ("Run clippy only on MSRV") to the release-0.13.x branch.


With the 0.13.2 release, clippy fails because of this. Port back the changes from #362 so that in our next patch release (if it happens), this does not break again.

This patch reverts the matrix for the clippy job to only run clippy on
our MSRV instead of stable, beta and nightly.

The recurring issue with this was that lints started failing in PRs that
couldn't have been fixed in master yet, because master was never tested
with a clippy that new (in case of nightly).

1.56.1 is good enough for now.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit 336a34e)
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
(cherry picked from commit d54986c)
@matthiasbeyer matthiasbeyer merged commit 46e6afc into mehcode:release-0.13.x Aug 2, 2022
@matthiasbeyer matthiasbeyer deleted the release-0.13.x-backport-362 branch August 2, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant