Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BeaconBlockBody with AttestationContainer #37

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

mehdi-aouadi
Copy link
Owner

PR Description

Update BeaconBlockBody container with AttestationContainer

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@mehdi-aouadi
Copy link
Owner Author

mehdi-aouadi commented Apr 23, 2024

This PR breaks the compilation and introduces incomplete changes. Missing thing:

  • Check TODOs
  • AggregateAndProof conatiner must be gentrified to handle both Attestation and AttestationElectra (using AttestationContainer like the BeaconBlockBody)
  • The json annotated tech.pegasys.teku.api.schema.SignedBeaconBlock and its subclasses should be refactored according to the tech.pegasys.teku.api.schema.BeaconBlockBody hierarchy refcatoring
  • Some Attestation casting have been added just to keep things working temporarily and should be removed/reviewed

@mehdi-aouadi mehdi-aouadi merged commit 652c9ca into EIP-7549 Apr 23, 2024
5 checks passed
@mehdi-aouadi mehdi-aouadi deleted the refactor-block-body branch May 29, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant