New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added separator option for output path and module arrays #4

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@tomwayson
Contributor

tomwayson commented Apr 17, 2014

Allow users to specify the separator (' ', '\n', '\n\t', etc) they would like to use between elements of the output arrays for modules and paths in the optimized content. Defaults to empty space (' ') so original behavior is not modified if this option is not supplied.

Also added documentation for this option to README.md.

NOTE I did not update package versions, etc.

@mehdishojaei

This comment has been minimized.

Show comment
Hide comment
@mehdishojaei

mehdishojaei Apr 18, 2014

Owner

That's a good idea, but i think instead of providing a global separator option, it's better to preserve the original separators of the source files by modifying RegExps (i'm currently working on). We can save the format of each source file in this manner. In other hand this module must not change the original format of source files.

Owner

mehdishojaei commented Apr 18, 2014

That's a good idea, but i think instead of providing a global separator option, it's better to preserve the original separators of the source files by modifying RegExps (i'm currently working on). We can save the format of each source file in this manner. In other hand this module must not change the original format of source files.

@tomwayson

This comment has been minimized.

Show comment
Hide comment
@tomwayson

tomwayson Apr 18, 2014

Contributor

I agree - I had the same thought while working on this, but it seemed like more work than I could take on right now. I'm glad you're working on it!

Contributor

tomwayson commented Apr 18, 2014

I agree - I had the same thought while working on this, but it seemed like more work than I could take on right now. I'm glad you're working on it!

@mehdishojaei

This comment has been minimized.

Show comment
Hide comment
@mehdishojaei

mehdishojaei Apr 18, 2014

Owner

Thanks for your good PR.

Owner

mehdishojaei commented Apr 18, 2014

Thanks for your good PR.

@tomwayson

This comment has been minimized.

Show comment
Hide comment
@tomwayson

tomwayson Apr 18, 2014

Contributor

NP - thanks for your thoughtful consideration! I'm glad you have a better solution in the works, also better that it's your regEx skills working on it than mine. ;)

Contributor

tomwayson commented Apr 18, 2014

NP - thanks for your thoughtful consideration! I'm glad you have a better solution in the works, also better that it's your regEx skills working on it than mine. ;)

@mehdishojaei

This comment has been minimized.

Show comment
Hide comment
@mehdishojaei

mehdishojaei Apr 19, 2014

Owner

@tomwayson Preserving the original separators of the source files now completed.

Owner

mehdishojaei commented Apr 19, 2014

@tomwayson Preserving the original separators of the source files now completed.

@tomwayson

This comment has been minimized.

Show comment
Hide comment
@tomwayson

tomwayson Apr 21, 2014

Contributor

Nice work! Thanks!

Contributor

tomwayson commented Apr 21, 2014

Nice work! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment