Added separator option for output path and module arrays #4

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@tomwayson
Contributor

Allow users to specify the separator (' ', '\n', '\n\t', etc) they would like to use between elements of the output arrays for modules and paths in the optimized content. Defaults to empty space (' ') so original behavior is not modified if this option is not supplied.

Also added documentation for this option to README.md.

NOTE I did not update package versions, etc.

@mehdishojaei
Owner

That's a good idea, but i think instead of providing a global separator option, it's better to preserve the original separators of the source files by modifying RegExps (i'm currently working on). We can save the format of each source file in this manner. In other hand this module must not change the original format of source files.

@tomwayson
Contributor

I agree - I had the same thought while working on this, but it seemed like more work than I could take on right now. I'm glad you're working on it!

@tomwayson tomwayson referenced this pull request in mehdishojaei/grunt-amdcheck Apr 18, 2014
Merged

added option to only write out files that have unused dependencies #5

@mehdishojaei
Owner

Thanks for your good PR.

@tomwayson
Contributor

NP - thanks for your thoughtful consideration! I'm glad you have a better solution in the works, also better that it's your regEx skills working on it than mine. ;)

@mehdishojaei
Owner

@tomwayson Preserving the original separators of the source files now completed.

@tomwayson
Contributor

Nice work! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment