Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract theme module #50

Closed
mhdabbaghy opened this issue Jul 16, 2023 · 4 comments · Fixed by #51
Closed

Extract theme module #50

mhdabbaghy opened this issue Jul 16, 2023 · 4 comments · Fixed by #51

Comments

@mhdabbaghy
Copy link
Collaborator

Extract the theme files to ":core:designsystme:theme" and move the related files to it

@mhdabbaghy mhdabbaghy linked a pull request Jul 16, 2023 that will close this issue
5 tasks
@mhdabbaghy
Copy link
Collaborator Author

@mehdiyari, I thought that I added all compose dependencies to this module (Material3, Animation, Ui-tooling) so it's not limited to the theme
A better name would be more appropriate.
or considering that we ignore more separation for now and add ":core:designsystem" and add all related design stuff to it (shared drawable, strings, etc) and separate it in the future if needed

@mehdiyari
Copy link
Owner

Hey @mhdabbaghy, Thanks.

The first thing that I want to tell you, based on our convention for modularization, is that we want to use something other than core or base names. We can have the design system modules in the design or shared directory.

:shared:designsystme:theme

@mehdiyari
Copy link
Owner

@mehdiyari, I thought that I added all compose dependencies to this module (Material3, Animation, Ui-tooling) so it's not limited to the theme A better name would be more appropriate. or considering that we ignore more separation for now and add ":core:designsystem" and add all related design stuff to it (shared drawable, strings, etc) and separate it in the future if needed

Having this dependency inside the theme and providing dependencies as API to the rest of the modules is okay. Let's focus on getting the job done, and we can improve it in the future.

@mhdabbaghy
Copy link
Collaborator Author

Hey @mhdabbaghy, Thanks.

The first thing that I want to tell you, based on our convention for modularization, is that we want to use something other than core or base names. We can have the design system modules in the design or shared directory.

:shared:designsystme:theme

Thanks @mehdiyari
I prefer design than shared,
But as you mentioned, let's get things done, i have no argue on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants