Fix for Database::_sort (UnionOfRAD#986). Will not output ORDER BY cl…

…ause if given field is empty (ie. if = array()). Updated a test case.
mehlah · Jul 16, 2013 · 218081c · 218081c
1 parent 81c873a
commit 218081c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/data/source/Database.php b/data/source/Database.php
@@ -1243,7 +1243,7 @@ protected function _sort($field, $context, $clause = 'ORDER BY', $direction = tr
 			$field = array($field => $direction);
 		}
 
-		if (!is_array($field)) {
+		if (!is_array($field) || empty($field)) {
 			return;
 		}
 		$result = array();

diff --git a/tests/cases/data/source/DatabaseTest.php b/tests/cases/data/source/DatabaseTest.php
@@ -607,6 +607,10 @@ public function testOrder() {
 		$result = $this->_db->order(array('author_id', "title" => "DESC"), $query);
 		$expected = 'ORDER BY {MockDatabasePost}.{author_id} ASC, {MockDatabasePost}.{title} DESC';
 		$this->assertEqual($expected, $result);
+
+		$result = $this->_db->order(array(), $query);
+		$expected = '';
+		$this->assertEqual($expected, $result);
 	}
 
 	public function testOrderOnRelated() {