Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for default shells other than Bash #43

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

cljoly
Copy link
Contributor

@cljoly cljoly commented Mar 16, 2023

I use Fish [1] as my default shell and this causes the preview window to
fail for gh commands (Fish uses bits of non-POSIX syntax).

This is because Fzf uses the default shell (set in the $SHELL
environment variable) to run the commands passed as arguments to bind.
Since the script is written in Bash, Bash is already a requirement.
Furthermore, the actions on binding are also written with Bash in mind,
so it makes sense in my opinion to instruct Fzf to use this shell.

[1] https://fishshell.com/

I use Fish [1] as my default shell and this causes the preview window to
fail for gh commands (Fish uses bits of non-POSIX syntax).

This is because Fzf uses the default shell (set in the `$SHELL`
environment variable) to run the commands passed as arguments to bind.
Since the script is written in Bash, Bash is already a requirement.
Furthermore, the actions on binding are also written with Bash in mind,
so it makes sense in my opinion to instruct Fzf to use this shell.

[1] https://fishshell.com/
@meiji163 meiji163 merged commit 4f6ca16 into meiji163:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants