Fix for default shells other than Bash#43
Merged
Conversation
I use Fish [1] as my default shell and this causes the preview window to fail for gh commands (Fish uses bits of non-POSIX syntax). This is because Fzf uses the default shell (set in the `$SHELL` environment variable) to run the commands passed as arguments to bind. Since the script is written in Bash, Bash is already a requirement. Furthermore, the actions on binding are also written with Bash in mind, so it makes sense in my opinion to instruct Fzf to use this shell. [1] https://fishshell.com/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use Fish [1] as my default shell and this causes the preview window to
fail for gh commands (Fish uses bits of non-POSIX syntax).
This is because Fzf uses the default shell (set in the
$SHELLenvironment variable) to run the commands passed as arguments to bind.
Since the script is written in Bash, Bash is already a requirement.
Furthermore, the actions on binding are also written with Bash in mind,
so it makes sense in my opinion to instruct Fzf to use this shell.
[1] https://fishshell.com/