Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder search #771

Merged
merged 3 commits into from Jul 3, 2020
Merged

Conversation

MarinPostma
Copy link
Contributor

close #729

meilisearch-core/src/query_builder.rs Outdated Show resolved Hide resolved
meilisearch-core/src/query_builder.rs Outdated Show resolved Hide resolved
meilisearch-core/src/query_builder.rs Outdated Show resolved Hide resolved
meilisearch-core/src/query_builder.rs Outdated Show resolved Hide resolved
@MarinPostma MarinPostma marked this pull request as ready for review June 12, 2020 14:59
@MarinPostma MarinPostma marked this pull request as draft June 12, 2020 15:07
@MarinPostma MarinPostma marked this pull request as ready for review June 12, 2020 16:26
@MarinPostma MarinPostma force-pushed the placeholder-search branch 4 times, most recently from b17c3c8 to 7c894cc Compare June 16, 2020 10:31
meilisearch-core/src/bucket_sort.rs Outdated Show resolved Hide resolved
meilisearch-core/src/bucket_sort.rs Outdated Show resolved Hide resolved
meilisearch-core/src/query_builder.rs Outdated Show resolved Hide resolved
meilisearch-core/src/query_builder.rs Outdated Show resolved Hide resolved
meilisearch-core/src/query_builder.rs Outdated Show resolved Hide resolved
meilisearch-core/src/store/main.rs Outdated Show resolved Hide resolved
meilisearch-core/src/update/documents_deletion.rs Outdated Show resolved Hide resolved
meilisearch-http/tests/placeholder_search.rs Outdated Show resolved Hide resolved
@curquiza
Copy link
Member

curquiza commented Jun 30, 2020

Can you add the label meilisearch-http since only this PR is added to the v0.13.0 Milestones and no the issue? 🙂

CHANGELOG.md Outdated
@@ -1,3 +1,8 @@
## v0.12.0 (unreleased)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## v0.12.0 (unreleased)
## v0.13.0 (unreleased)

@@ -255,6 +255,10 @@ pub fn apply_addition<'a, 'b>(
let facet_map = facets::facet_map_from_docids(writer, index, &docids, attributes_for_facetting.as_ref())?;
index.facets.add(writer, facet_map)?;
}
//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//

@@ -352,6 +356,10 @@ pub fn reindex_all_documents(writer: &mut heed::RwTxn<MainT>, index: &store::Ind
let facet_map = facets::facet_map_from_docids(writer, index, &docids, attributes_for_facetting.as_ref())?;
index.facets.add(writer, facet_map)?;
}
//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//

meilisearch-http/tests/common.rs Show resolved Hide resolved
@MarinPostma MarinPostma force-pushed the placeholder-search branch 3 times, most recently from 7848714 to 5ec6bf6 Compare July 2, 2020 16:53
@Kerollmops Kerollmops merged commit 2f6c55e into meilisearch:master Jul 3, 2020
loiclec pushed a commit that referenced this pull request Jan 23, 2023
771: Update version for the next release (v0.40.0) in Cargo.toml files r=curquiza a=meili-bot

⚠️ This PR is automatically generated. Check the new version is the expected one before merging.

Co-authored-by: curquiza <curquiza@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue: Placeholder search or a search without query parameters
3 participants