Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove maintenance error from http #1082

Merged
merged 2 commits into from Nov 19, 2020
Merged

remove maintenance error from http #1082

merged 2 commits into from Nov 19, 2020

Conversation

MarinPostma
Copy link
Contributor

remove the maintenance error from meilisearch-http

close #1061

@MarinPostma MarinPostma added this to the 12/2020 milestone Nov 16, 2020
@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #1082 (6f48f37) into master (ef6b56d) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1082      +/-   ##
==========================================
+ Coverage   76.53%   76.57%   +0.03%     
==========================================
  Files         104      104              
  Lines       12127    12121       -6     
==========================================
  Hits         9282     9282              
+ Misses       2845     2839       -6     
Impacted Files Coverage Δ
meilisearch-error/src/lib.rs 67.64% <ø> (+0.98%) ⬆️
meilisearch-http/src/error.rs 50.00% <ø> (+1.38%) ⬆️
meilisearch-core/src/bucket_sort.rs 81.34% <0.00%> (-0.06%) ⬇️
meilisearch-core/src/number.rs 31.78% <0.00%> (ø)
meilisearch-http/tests/common.rs 90.86% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a67862...2eaab48. Read the comment docs.

@ManyTheFish ManyTheFish self-requested a review November 19, 2020 15:01
@ManyTheFish
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Nov 19, 2020
@bors
Copy link
Contributor

bors bot commented Nov 19, 2020

try

Build succeeded:

@MarinPostma
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 19, 2020

Build succeeded:

@bors bors bot merged commit aab041e into master Nov 19, 2020
@bors bors bot deleted the remove-maintenance-error branch November 19, 2020 16:07
@MarinPostma MarinPostma removed the RFR label Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the Maintenance error
2 participants