Changes related to the next MeiliSearch release (v0.21.0) #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meili-bot
added
the
skip-changelog
alallema
added
breaking-change
Update README
Rename attributes_for_faceting into filterable_attributes
Update PendingUpdateX
Rename Filters into Filter
Adding tests
bidoubiwa
reviewed
Aug 24, 2021
bidoubiwa
previously requested changes
Aug 24, 2021
Contributor
bidoubiwa
left a comment
bidoubiwa
left a comment
There was a problem hiding this comment.
Synonyms/Stop words value to null has been updated in the setting structure but not in their respective functions:
Future<PendingUpdate> updateStopWords(List<String> stopWords);
/// Update synonyms of the index
Future<PendingUpdate> updateSynonyms(Map<String, List<String>> synonyms);
Comment on lines
+100
to
+110
| test('facetDistributions parameter', () async { | ||
| var index = await createBooksIndex(); | ||
| var response = await index | ||
| .updateSettings(IndexSettings( | ||
| filterableAttributes: ['tag'], | ||
| )) | ||
| .waitFor(); | ||
| expect(response.status, 'processed'); | ||
| var result = await index.search('prince', facetsDistribution: ['*']); | ||
| expect(result.hits, hasLength(2)); | ||
| }); |
Contributor
There was a problem hiding this comment.
Should we add a test on the returned facetDistribution? To test if no 0 values are present. I'm not sure it is needed but out of curiosity
Member
There was a problem hiding this comment.
This is a test for the search engine from my POV, plus this test is already present in many SDKs :)
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this issue: meilisearch/integration-guides#117
This PR:
This PR is auto-generated for the pre-release week purpose. Exceptionally for this release, the pre-release time will be more than just one week.
Done:
attributes_for_facetingintofilterable_attributesRename attributes_for_faceting into filterable_attributes #61processingstatus to check inPendingUpdateX()method Update PendingUpdateX #62