-
Notifications
You must be signed in to change notification settings - Fork 32
Changes related to the next MeiliSearch release (v0.21.0) #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
e976081
Update README.md
meili-bot 8bbbacf
Merge branch 'main' into bump-meilisearch-v0.21.0
curquiza b47a922
Merge branch 'main' into bump-meilisearch-v0.21.0
curquiza 089a6a8
Merge branch 'main' into bump-meilisearch-v0.21.0
curquiza 22db1b1
Update README
alallema 5db4c40
Merge pull request #60 from meilisearch/update-readme
alallema 4625c6f
Rename attributes_for_faceting into filterable_attributes
alallema 23af865
Merge pull request #61 from meilisearch/filterable_attributes
alallema 4e68078
Adding processing in the condition to check
alallema 033a6f9
Merge pull request #62 from meilisearch/improve-wfpu
alallema fdc1cea
Rename Filters in Filter and remove FacetFilters
alallema b72d2db
Merge pull request #63 from meilisearch/filter
alallema 5bd9cc1
Adding test for new features
alallema 6cd496c
Fixing Linter
alallema 0a6c0d5
Merge pull request #64 from meilisearch/add-tests
alallema cdd4c7f
Add tests and fix filter
alallema 7b0a665
Fix linter
alallema dccc03f
Merge pull request #65 from meilisearch/add-tests
alallema ff74a77
Merge branch 'main' into bump-meilisearch-v0.21.0
curquiza b717cad
Merge branch 'main' into bump-meilisearch-v0.21.0
curquiza 8bce5e5
Rename attributes for faceting into filterable attributes (#71)
curquiza 2575a70
Fix tests (#72)
curquiza d35847f
Update lib/src/index_settings.dart
curquiza 67a81ad
Merge branch 'main' into bump-meilisearch-v0.21.0
curquiza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a test on the returned facetDistribution? To test if no
0values are present. I'm not sure it is needed but out of curiosityUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a test for the search engine from my POV, plus this test is already present in many SDKs :)