-
Notifications
You must be signed in to change notification settings - Fork 32
Null-safety migration #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Actually I think nnbd version should be maintained separately on different branch for some time. At least that's what we did when migrating hive to nnbd. |
|
Hello @themisir! Thanks for doing this work :) |
|
@curquiza it's ready. Just updated |
curquiza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated |
Remove nnbd branch from workflow branches Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
My bad, I miss checked! :) |
Update dependency version to: `meilisearch: ^0.2.0`
curquiza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!! 🔥 Thanks @themisir!
|
bors merge |
|
Build succeeded: |
|
@curquiza out of context, but what does bors exactly? |
|
TLDR: Bors is a tool that applies a rebase before running the tests and finally merging if they succeed. To be more accurate, Bors does not concretely rebase the branch of the PR: it merges the commits of the PR into another branch (staging) that is already up-to-date with main. If the tests do not pass on the staging branch, Bors returns a failure and stops the merge of the PR. We use it because:
I wrote a guide about it here: https://github.com/meilisearch/integration-guides/blob/main/guides/bors.md Also, bors is a tool widely used (and created) by the rust community |
|
Thanks 🙏 |
Fixes #37