Add support for multiple sort attributes #1041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1e6fe28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Incredible contribution 🔥🔥🔥 Thanks a lot. Could you add a changeset ? |
Contributor
Author
|
@bidoubiwa Done! |
bidoubiwa
reviewed
Mar 28, 2023
Contributor
bidoubiwa
left a comment
bidoubiwa
left a comment
There was a problem hiding this comment.
Thanks for the changeset :) I reviewed your code and its good! Could you also update the sortBy section in the readme by adding some info about this new usage?
…arch into add/support-for-multiple-sort-attributes
Contributor
Author
|
@bidoubiwa I have updated the readme. |
bidoubiwa
approved these changes
Mar 29, 2023
Contributor
bidoubiwa
left a comment
bidoubiwa
left a comment
There was a problem hiding this comment.
Thanks a lot 🙏 This is a very nice PR
Contributor
|
bors merge |
Contributor
Contributor
Author
|
@bidoubiwa Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
I created a new pull request with changes that @bidoubiwa requested in pull request #1024.
Related issue
Fixes #539
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements: