Skip to content

Updation of node version used in CI from 16 to 18 #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Updation of node version used in CI from 16 to 18 #1121

wants to merge 2 commits into from

Conversation

@warlegend24
Copy link

@warlegend24 warlegend24 commented May 31, 2023

Pull Request

Related issue

Fixes # 1119

What does this PR do?

  • Updates the node version used in CI from 16 to 18

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@warlegend24
Updated the CI version from 16 to 18 in pre-release-tests.yml
d78fae8 
Updation done:-
```diff
-node-version: 16 
+node-version: 18
```
@warlegend24
Updated the Cl version to 18 in *meilisearch-prototype-tests.yml*
14981b1 
Updation done 👍 
```diff
-node-version: 16 
+node-version: 18
```
@changeset-bot
Copy link

changeset-bot bot commented May 31, 2023

⚠️ No Changeset found

Latest commit: 14981b1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

bidoubiwa
bidoubiwa suggested changes May 31, 2023
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks a lot for your contribution.

You forgot some files where the node version is still 16 and there is a newline issue in the pre-release-tests.yml file :)

@tungbq tungbq mentioned this pull request May 31, 2023
Merged
3 tasks
@warlegend24
Copy link
Author

warlegend24 commented May 31, 2023

hey there....sorry for the missing data to be updated....I have created a new PR making sure every node-version is updated
Can you plz accept my PR as it is my first open source contribution :)

@bidoubiwa
Copy link
Contributor

bidoubiwa commented May 31, 2023

closed in favor of #1122

Thanks for the contribution though, even if it was not merged

@bidoubiwa bidoubiwa closed this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bidoubiwa bidoubiwa bidoubiwa requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@warlegend24 @bidoubiwa