Skip to content

Conversation

@tungbq
Copy link
Contributor

@tungbq tungbq commented May 31, 2023

Pull Request

Related issue

Fixes #1119

What does this PR do?

Upgrade node version in CI workflows (from node 16 to node 18) in following files:

  • .github/workflows/meilisearch-prototype-tests.yml
  • .github/workflows/pre-release-tests.yml
  • .github/workflows/publish.yml
  • .github/workflows/tests.yml

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2023

⚠️ No Changeset found

Latest commit: f909cb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks a lot for this PR :)

You missed one in this file: https://github.com/meilisearch/instant-meilisearch/blob/main/.github/workflows/publish.yml

@tungbq
Copy link
Contributor Author

tungbq commented May 31, 2023

Hey! Thanks a lot for this PR :)

You missed one in this file: https://github.com/meilisearch/instant-meilisearch/blob/main/.github/workflows/publish.yml

Thanks for reviewing. I got it and updated in the latest commit. Please review again

@tungbq tungbq requested a review from bidoubiwa May 31, 2023 14:46
Copy link

@warlegend24 warlegend24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey can you plz tell me how did you made 3 commits in 3 different files and merged them into a single pull request

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ✨ Thanks a lot for this contribution :)

@bidoubiwa
Copy link
Contributor

bors merge

@bidoubiwa
Copy link
Contributor

bors merge

@bidoubiwa
Copy link
Contributor

bors r-

@bidoubiwa bidoubiwa merged commit 7ced091 into meilisearch:main Jun 1, 2023
@meili-bot
Copy link
Contributor

This message is sent automatically

Thank you very much for submitting your PR! Did you know that throughout the month of June we’re holding a rafle?
If you share the link to your merged PR in our #giveaway Discord channel, you’ll automatically join a lottery for a chance at winning some Meiliswag. 🙂
Don’t hesitate to join us: https://discord.com/channels/1006923006964154428/1111273670657200198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change node version used in CI from 16 to 18

5 participants