-
Notifications
You must be signed in to change notification settings - Fork 66
Upgrade node version in CI workflows #1122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
bidoubiwa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Thanks a lot for this PR :)
You missed one in this file: https://github.com/meilisearch/instant-meilisearch/blob/main/.github/workflows/publish.yml
Thanks for reviewing. I got it and updated in the latest commit. Please review again |
warlegend24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey can you plz tell me how did you made 3 commits in 3 different files and merged them into a single pull request
bidoubiwa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ✨ Thanks a lot for this contribution :)
|
bors merge |
|
bors merge |
|
bors r- |
|
This message is sent automatically Thank you very much for submitting your PR! Did you know that throughout the month of June we’re holding a rafle? |
Pull Request
Related issue
Fixes #1119
What does this PR do?
Upgrade node version in CI workflows (from node 16 to node 18) in following files:
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!