Skip to content

Update meilisearch js to v0.33.0 #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2023
Merged

Update meilisearch js to v0.33.0 #1134

merged 2 commits into from
Jun 5, 2023

Conversation

@bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Jun 5, 2023

Update meilisearch-js to v0.33.0 and fix a failing tests introduced by the new version of Meilisearch (the engine) v1.2.0.

This failing test is due to a change in the way the cropping is processed on Meilisearch sides and is considered not a breaking change.
The test was changed to be more robust.

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Jun 5, 2023
@bidoubiwa bidoubiwa requested a review from brunoocasali June 5, 2023 13:45
@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2023

⚠️ No Changeset found

Latest commit: 53affc1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bidoubiwa bidoubiwa marked this pull request as ready for review June 5, 2023 13:49
brunoocasali
brunoocasali approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 LGTM!

@bidoubiwa
Copy link
Contributor Author

bidoubiwa commented Jun 5, 2023

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jun 5, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 684256b into main Jun 5, 2023
@meili-bors meili-bors bot deleted the update_meilisearch_js_to_v0.33.0 branch June 5, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees

No one assigned

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bidoubiwa @brunoocasali