-
Notifications
You must be signed in to change notification settings - Fork 66
Re-export meilisearch package, and expose created MeiliSearch instance
#1271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
meili-bors
merged 4 commits into
meilisearch:main
from
flevi29:expose-meilisearch-package
Feb 27, 2024
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
234d699
Exposed created MeiliSearch instance, re-exported all of "meilisearch…
flevi29 1cd081e
Removed redundant "resolveJsonModule" in tsconfig.test.json, as it's …
flevi29 ac6eb90
Merge branch 'main' into expose-meilisearch-package
flevi29 ad3c63b
Merge branch 'main' into expose-meilisearch-package
brunoocasali File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| --- | ||
| "@meilisearch/instant-meilisearch": minor | ||
| --- | ||
|
|
||
| - exposed created `MeiliSearch` instance | ||
| - re-exported all of `"meilisearch"` package | ||
|
|
||
| These improvements make it so that no separate `"meilisearch"` package | ||
| has to be installed in order to use its exports directly. This | ||
| way a single `MeiliSearch` instance can be re-used, and we can potentially | ||
| save on bundle size by avoiding a separate different version installation of | ||
| `"meilisearch"`. | ||
|
|
||
| ```typescript | ||
| import { instantMeiliSearch, meilisearch } from '@meilisearch/instant-meilisearch' | ||
| // re-exported "meilisearch" ^ | ||
|
|
||
| const { | ||
| meiliSearchInstance, | ||
| // ^ re-usable MeiliSearch instance | ||
| searchClient | ||
| } = instantMeiliSearch(/*...*/) | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| export * from './client' | ||
| export * from './types' | ||
| export * as meilisearch from 'meilisearch' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -2,7 +2,6 @@ | |||
| "extends": "./tsconfig.json", | ||||
| "compilerOptions": { | ||||
| "suppressImplicitAnyIndexErrors": true, | ||||
| "resolveJsonModule": true | ||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👀 can you explain that 😅 ?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's already set as
|
||||
| }, | ||||
| "include": [ | ||||
| "./**/*" | ||||
|
|
||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.