Typescript first #249
Merged
Typescript first #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
force-pushed
the
typescript-first
branch
from
7d341af to
ce8440f
Compare
bidoubiwa
added
the
breaking-change
curquiza
reviewed
Feb 10, 2021
curquiza
reviewed
Feb 10, 2021
curquiza
reviewed
Feb 10, 2021
curquiza
reviewed
Feb 10, 2021
curquiza
reviewed
Feb 10, 2021
curquiza
reviewed
Feb 10, 2021
curquiza
approved these changes
Feb 10, 2021
Member
There was a problem hiding this comment.
Huge work! thanks @bidoubiwa!
I let your merge when you are ready!
Contributor
Author
|
bors merge |
Contributor
|
Build succeeded: |
This was referenced Feb 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript conversion
Types update
Types have been improved and are compatible with instant search types.
Linting update
All envs and playgrounds are linted based on the root eslint config file.
Jest updates
as in meilisearch-js meilisearch/meilisearch-js#760 the jest jsdom had to be updated for the tests to succeed in node 10. #255
Testing
Add build before tests for env tests using jest to succeed.
Add build of playgrounds in CI to determine if they correctly extract instant-meilisearch.
Add instantsearch.js as a dev dependency as it is used for testing purposes
Add some nodejs tests that tries instantsearch compatibility with instant-meilisearch
Add a typescript
Playgrounds
Naming
Methods inside instant-meilisearch function have been renamed for more clarity