Remove tests on remote meilisearch server #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
added
the
skip-changelog
bidoubiwa
force-pushed
the
remove_remote_tests
branch
from
fc2a9cc to
b481799
Compare
bidoubiwa
force-pushed
the
remove_remote_tests
branch
from
b481799 to
5213bc8
Compare
Contributor
Author
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Feb 1, 2022
659: Remove tests on remote meilisearch server r=bidoubiwa a=bidoubiwa fixes: #542 Since tests were only done on one environment any way during CI but also local testing I removed the testing all together on playground using the remote meilisearch instance Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
Contributor
|
Build failed: |
Contributor
Author
|
bors try |
Contributor
tryBuild succeeded: |
brunoocasali
reviewed
Feb 1, 2022
alallema
approved these changes
Feb 2, 2022
Contributor
alallema
left a comment
alallema
left a comment
There was a problem hiding this comment.
LGTM!
I just add a comment but I don't think it's relevant so I approve it! 🦩
brunoocasali
reviewed
Feb 4, 2022
| - name: Install dependencies | ||
| run: yarn --dev && yarn --cwd ./playgrounds/vue | ||
| - name: Run Browser tests | ||
| run: yarn --dev && yarn --cwd ./tests/env/react |
Member
There was a problem hiding this comment.
Should we create a matrix with react, vue, angular and vanilla javascript? Just in case to prevent possible breaking between them.
Contributor
Author
There was a problem hiding this comment.
It would take a very very long time for the tests to run. I thought maybe run them once a week in a scheduled job but not on every PR. What do you think ?
Contributor
Author
|
bors merge |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #642
Since tests were only done on one environment any way during CI but also local testing I removed the testing all together on playground using the remote meilisearch instance