Skip to content

Test that ellipsis on smaller values than cropsize are not added #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2022
Merged

Test that ellipsis on smaller values than cropsize are not added #704

merged 1 commit into from
Mar 22, 2022

Conversation

@bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Mar 22, 2022

fixes: #577

@bidoubiwa bidoubiwa force-pushed the cropping_on_smaller_size_not_ellipsed branch from 9c7b6c9 to aa1f763 Compare March 22, 2022 12:09
@bidoubiwa bidoubiwa force-pushed the cropping_on_smaller_size_not_ellipsed branch from aa1f763 to d597c7a Compare March 22, 2022 12:09
alallema
alallema approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌯

@bidoubiwa
Copy link
Contributor Author

bidoubiwa commented Mar 22, 2022

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Mar 22, 2022

Build succeeded:

@meili-bors meili-bors bot merged commit b9807ee into main Mar 22, 2022
@meili-bors meili-bors bot deleted the cropping_on_smaller_size_not_ellipsed branch March 22, 2022 15:25
@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunoocasali brunoocasali Awaiting requested review from brunoocasali

1 more reviewer

@alallema alallema alallema approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove snippetEllipsisText when string is smaller than snippetSize

3 participants

@bidoubiwa @alallema