Skip to content

Update beta guide in contributing #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2022
Merged

Update beta guide in contributing #816

merged 1 commit into from
Aug 1, 2022

Conversation

@bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Aug 1, 2022

The beta guide was wrongly telling the user to create a specific formated branch which is not the one required.

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Aug 1, 2022
alallema
alallema approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM! ✨

@bidoubiwa
Copy link
Contributor Author

bidoubiwa commented Aug 1, 2022

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Aug 1, 2022

Build succeeded:

@meili-bors meili-bors bot merged commit b50fb65 into main Aug 1, 2022
@meili-bors meili-bors bot deleted the update_beta_guide branch August 1, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunoocasali brunoocasali Awaiting requested review from brunoocasali

1 more reviewer

@alallema alallema alallema approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bidoubiwa @alallema