-
Notifications
You must be signed in to change notification settings - Fork 67
Add beta release process #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| run: yarn build | ||
| - name: Publish with latest tag | ||
| if: "!github.event.release.prerelease && !contains(github.ref, 'beta')" | ||
| if: '!github.event.release.prerelease' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the step Check tag format we ensure that, in the case we are in a latest release and not a pre-release, the version of the package is strictly formatted as vX.X.X and not for example vX.X.X-my-feature.0.
With that check, we do not need the second condition anymore.
03cf4b7 to
abd0032
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be fully transparent, I don't feel confident reviewing this, I made this at the end of my day. However, the main structure seems present.
I would maybe add a small paragraph to explain the different kind of beta we have in this repo, like you did in the PR description
After this, let's try this in production 😄
|
Hey @curquiza If yes, what do you think of this?
|
|
brunoocasali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Very good, the comments helped a lot the code review!
|
bors merge |
This repository is able to create mutiple types of beta:
Each of these beta must run against a specific version of Meilisearch.
This PR introduces the new process to make this as simple as possible. To be able to redirect the PR's to the correct tests a new formating is suggested on the branch name. For consistency, a new formating is suggested on the package version.
The
check-tag-versionscript ensures that if the version is not avX.X.Xit should be a pre-release.the
prototype-docker-versionparse the branch name to fetch the correct image on the docker API.