Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed sphinx action and added manual buid of docs, closes #550 #558

Merged
merged 1 commit into from Oct 13, 2022

Conversation

kaggrwal
Copy link
Contributor

Pull Request

Related issue

Fixes #550

What does this PR do?

  • This removes the sphinx action and manually builds the documentation using sphinx via pipenv

PR checklist

Please check if your PR fulfills the following requirements:

  • [ ✓] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • [ ✓] Have you read the contributing guidelines?
  • [ ✓] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@kaggrwal
Copy link
Contributor Author

@alallema Please review and merge it.

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kaggrwal for this PR
LGTM!

@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 13, 2022

@bors bors bot merged commit 6373bc6 into meilisearch:main Oct 13, 2022
@alallema
Copy link
Contributor

This message is sent automatically

Thanks again for contributing to Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.

@alallema alallema added hacktoberfest skip-changelog The PR will not appear in the release changelogs labels Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check alternative to sphinx-action
3 participants