Skip to content

Update readme #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 9, 2021
Merged

Update readme #32

merged 14 commits into from
Jun 9, 2021

Conversation

@CaroFG
Copy link
Contributor

@CaroFG CaroFG commented Jun 3, 2021 •
edited
Loading

Closes #19

@CaroFG CaroFG marked this pull request as ready for review June 7, 2021 16:14
@CaroFG CaroFG requested a review from curquiza June 7, 2021 16:14
curquiza
curquiza requested changes Jun 9, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge and awesome work @CaroFG ❤️
The documentation you've done is awesome! I just require small changes

README.md Outdated
Create a new file `config/initializers/meilisearch.rb` to setup your `MEILISEARCH_HOST` and `MEILISEARCH_API_KEY`

```ruby

Copy link
Member

@curquiza curquiza Jun 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

README.md Outdated
# controller
@hits = Book.search('harry potter')


Copy link
Member

@curquiza curquiza Jun 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@CaroFG CaroFG requested a review from curquiza June 9, 2021 15:06
curquiza
curquiza reviewed Jun 9, 2021
View reviewed changes
CaroFG and others added 2 commits June 9, 2021 17:58
@CaroFG @curquiza
Apply suggestions from code review
6207a3b 
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
@CaroFG
Correct indentation
3ff3bb4
@CaroFG CaroFG requested a review from curquiza June 9, 2021 16:01
curquiza
curquiza approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!!! ❤️

@CaroFG
Copy link
Contributor Author

CaroFG commented Jun 9, 2021

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 9, 2021

Build succeeded:

@bors bors bot merged commit 4e48d45 into main Jun 9, 2021
@curquiza curquiza deleted the update-readme branch June 9, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curquiza curquiza curquiza approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add complete README

3 participants

@CaroFG @curquiza