Skip to content

Changes related to the next MeiliSearch release (v0.25.0) #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 13, 2022
Merged

Changes related to the next MeiliSearch release (v0.25.0) #92

merged 3 commits into from
Jan 13, 2022

Conversation

@meili-bot
Copy link
Contributor

@meili-bot meili-bot commented Dec 6, 2021

This PR gathers the changes related to the next MeiliSearch release (v0.25.0) so that this package is ready when the official release is out.

⚠️ This PR should NOT be merged until:

  • the next release of MeiliSearch (v0.25.0) is out.
  • the meilisearch-ruby dependency has been released to be compatible with MeiliSearch v0.25.0.
    Once the release is out, the meilisearch-ruby version in this package should be upgraded and committed to this branch.

This PR is auto-generated for the pre-release week purpose.

@meili-bot meili-bot added the skip-changelog The PR will not appear in the release changelogs label Dec 6, 2021
@curquiza curquiza added breaking-change The related changes are breaking for the users and removed skip-changelog The PR will not appear in the release changelogs labels Jan 12, 2022
@curquiza
Copy link
Member

curquiza commented Jan 12, 2022

This PR is breaking because uses meilisearch-ruby v0.18.0 that only works with MeiliSearch v0.25.0 and later -> it enforces the users to upgrade their MeiliSearch version

@curquiza
Merge branch 'main' into bump-meilisearch-v0.25.0
f38bd21
@curquiza
Bump meilisearch-ruby (v0.18.0) (#99)
b75a5c9 
* Use meilisearch-ruby v0.18.0
* Update tests according to the review
* Fix linter errors=
@brunoocasali brunoocasali self-requested a review January 13, 2022 17:06
@curquiza curquiza marked this pull request as ready for review January 13, 2022 17:08
brunoocasali
brunoocasali approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we were good to go! 💯

thaaaaanks! @curquiza

@brunoocasali
Copy link
Member

brunoocasali commented Jan 13, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 13, 2022

Build succeeded:

@bors bors bot merged commit c27fac2 into main Jan 13, 2022
@bors bors bot deleted the bump-meilisearch-v0.25.0 branch January 13, 2022 17:11
@brunoocasali brunoocasali mentioned this pull request Jan 13, 2022
Merged
bors bot added a commit that referenced this pull request Jan 13, 2022
@bors @brunoocasali
Merge #100
28088e6 
100: Update version for the next release (v0.4.0) r=brunoocasali a=brunoocasali

Why is it breaking?
- #99
- #92

Other relevant changes:
- #96
- #94

Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees

No one assigned

Labels

breaking-change The related changes are breaking for the users

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@meili-bot @curquiza @brunoocasali