Skip to content

Add simplecov #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2022
Merged

Add simplecov #96

merged 2 commits into from
Jan 10, 2022

Conversation

@jitingcn
Copy link
Contributor

@jitingcn jitingcn commented Dec 21, 2021

Fixes #85

brunoocasali
brunoocasali requested changes Jan 7, 2022
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jitingcn, first of all, thanks a lot for your time and your contribution! ❤️
And I'm really sorry for making you wait :/

Adding simplecov will help us to keep the code quality by ensuring that no new code will make the coverage down, thanks a lot!

@curquiza curquiza requested review from brunoocasali and removed request for curquiza January 10, 2022 09:29
brunoocasali
brunoocasali approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were good to go, thanks @jitingcn 🥇

@brunoocasali
Copy link
Member

brunoocasali commented Jan 10, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 10, 2022

Build succeeded:

@bors bors bot merged commit bdabe3b into meilisearch:main Jan 10, 2022
@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Jan 10, 2022
@brunoocasali brunoocasali mentioned this pull request Jan 13, 2022
Merged
bors bot added a commit that referenced this pull request Jan 13, 2022
@bors @brunoocasali
Merge #100
28088e6 
100: Update version for the next release (v0.4.0) r=brunoocasali a=brunoocasali

Why is it breaking?
- #99
- #92

Other relevant changes:
- #96
- #94

Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees

No one assigned

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add simplecov gem

3 participants

@jitingcn @brunoocasali @curquiza