Skip to content

Conversation

@loiclec
Copy link
Contributor

@loiclec loiclec commented Nov 16, 2022

See #358 (review) for an explanation of the change.

Additionally, a couple of references to crate were left in the proc macro, which were also changed to ::meilisearch_sdk.

romilpunetha and others added 2 commits November 16, 2022 11:21
* Adds  proc macro for easy index creation

* Formats index settings macro

* Tests the settings generated by the macro

* Fixes clippy warnings

* Fixes create index return type and primary key mandatory

* Fixes clippy warnings

* Tests for index creation by macro

* Creates index using struct name in snake case

* Apply suggestions from code review

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

* Addresses review changes

* Apply suggestions from code review

Co-authored-by: Loïc Lecrenier <loic.lecrenier@me.com>

* Addresses review changes

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Co-authored-by: Loïc Lecrenier <loic.lecrenier@me.com>
@loiclec loiclec requested a review from bidoubiwa November 16, 2022 11:00
@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Nov 16, 2022
@bidoubiwa
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Nov 16, 2022
@bors
Copy link
Contributor

bors bot commented Nov 16, 2022

@bidoubiwa
Copy link
Contributor

bors merge

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@bors
Copy link
Contributor

bors bot commented Nov 16, 2022

@bors bors bot merged commit 13da4de into main Nov 16, 2022
@bors bors bot deleted the add_macros_en_settings branch November 16, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants