Skip to content

Commit

Permalink
Change dumps_dir to dump_dir in config.toml
Browse files Browse the repository at this point in the history
  • Loading branch information
@dureuill
dureuill committed Dec 1, 2022
1 parent e35db5e commit daa0f2e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion config.toml
View file
Expand Up @@ -56,7 +56,7 @@ disable_auto_batching = false
### DUMPS ###
#############

dumps_dir = "dumps/"
dump_dir = "dumps/"
# Sets the directory where Meilisearch will create dump files.
# https://docs.meilisearch.com/learn/configuration/instance_options.html#dumps-destination

Expand Down

2 comments on commit daa0f2e

@akelder
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

With dumps_dir Meilisearch 0.30.2 starts up fine, but with dump_dir throws this error:

Dec 13 16:36:35 host systemd[1]: Started Meilisearch.
Dec 13 16:36:35 host meilisearch[27079]: Error: unknown field dump_dir at line 1 column 1
Dec 13 16:36:35 host systemd[1]: meilisearch.service: Main process exited, code=exited, status=1/FAILURE
Dec 13 16:36:35 host systemd[1]: meilisearch.service: Failed with result 'exit-code'.

Here's the version we're running:

Dec 13 16:41:02 host meilisearch[27104]: Commit SHA: "125f0b15228b342a0efd2877e77d69663b459077"
Dec 13 16:41:02 host meilisearch[27104]: Commit date: "2022-12-08T13:28:00Z"
Dec 13 16:41:02 host meilisearch[27104]: Package version: "0.30.2"

Regards,
Alain

@dureuill
Copy link
Contributor Author

@dureuill dureuill commented on daa0f2e Dec 14, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Alain (@akelder) 👋

As the change in parameter name from dumps_dir to dump_dir is a breaking change, it was not released to the 0.30.x branch. It is planned for the next major release of Meilisearch.
This change is located in commit 3bef6e6690a1483fbc1b9b0d6aa6f8c89933dc3b which was merged to the main branch, but is not a parent of commit 125f0b15228b342a0efd2877e77d69663b459077.

If you want to test this change you will have to compile from source the main branch (which may have some other breaking changes and will be unstable until release, so I'm not recommending you deploy in production just yet) or use our newly released nightly docker image (will have the same breaking changes and instability as the main branch)

Again, if you're using Meilisearch in production, I strongly suggest you stay on the 0.30.x versions until the release of the next major version.

Hope this helps 😊
Regards,
Louis

Please sign in to comment.