Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce parameters to limit the number of batched tasks #4249

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

Kerollmops
Copy link
Member

@Kerollmops Kerollmops commented Dec 11, 2023

This PR exposes a new environment variable and command line argument. Those parameters take a number and limit the number of tasks Meilisearch will process at once. Reducing the crash possibility due to Meilisearch using too much memory.

You can find the experimental feature product discussion and we also released a Docker file prototype for users to test it early and give feedback.

docker pull getmeili/meilisearch:prototype-limit-batched-tasks-1

Related issue

Fixes #4248

TODO

  • Make the flag experimental (by prefixing it)
  • Add the parameter in the config file (commented out)

@Kerollmops Kerollmops added this to the v1.6.0 milestone Dec 11, 2023
@Kerollmops Kerollmops changed the title Introduce parameters to limit the number of tasks to process in batches Introduce parameters to limit the number of batched tasks Dec 11, 2023
@curquiza
Copy link
Member

@ManyTheFish kero asked me to put you as reviewer because tamo tamo is sick 😢

Copy link
Member

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💯

@Kerollmops Kerollmops merged commit 0058006 into main Dec 13, 2023
9 checks passed
@Kerollmops Kerollmops deleted the flag-limit-batch-size branch December 13, 2023 09:32
@meili-bot meili-bot added the v1.6.0 PRs/issues solved in v1.6.0 released on 2024-01-15 label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.6.0 PRs/issues solved in v1.6.0 released on 2024-01-15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit the Number of Batched Tasks
4 participants