Fix hang on /indexes
and /stats
routes
#4308
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #4218
Context
IndexScheduler
to memorize thecurrently_updating_index
, so that accessing it through the search would return the handle without trying to open it. This resolved a hang on the search, but/indexes
and/stats
routes hang when search requests on multiple indexes are running #4218 reported further hangs on the/indexes
and/stats
routesIndexScheduler
and using internalIndexMapper
logic to access the indexes, again trying to reopen the updating index.What does this PR do?
currently_updating_index
from theIndexScheduler
to theIndexMapper
, so that any index request to theIndexMapper
can benefit from it.Test
/indexes
and/stats
routes hang when search requests on multiple indexes are running #4218/stats
and/indexes
, but not on/indexes/<updating_index>/search
/stats
,/indexes
or/indexes/<updating_index>/search