Skip to content

Fixes embedder issues#4371

Merged
meili-bors[bot] merged 2 commits intorelease-v1.6.1from
embedder_fixes
Jan 29, 2024
Merged

Fixes embedder issues#4371
meili-bors[bot] merged 2 commits intorelease-v1.6.1from
embedder_fixes

Conversation

@dureuill
Copy link
Contributor

Pull Request

Related issue

Fixes #4361
Fixes #4370

What does this PR do?

  • Truncate tokens to 512 for Hugging Face embedders
  • Move the tokio runtime to OpenAI so that we no longer have a thread with rayon -> tokio -> rayon
  • Spawn a new reqwest client after each new runtime to avoid spurious runtime error

Manual tests

  • embedding failing document from @CaroFG with hugging face
  • embedding movies with hugging face
  • embedding and searching movies with openai

@dureuill dureuill added this to the v1.6.1 milestone Jan 29, 2024
@dureuill dureuill requested a review from irevoire January 29, 2024 10:30
Copy link
Contributor

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jan 29, 2024

@meili-bors meili-bors bot merged commit 049bd45 into release-v1.6.1 Jan 29, 2024
@meili-bors meili-bors bot deleted the embedder_fixes branch January 29, 2024 12:09
@meili-bot meili-bot added the v1.6.1 PRs/issues solved in v1.6.1 released on 2024-02-05 label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v1.6.1 PRs/issues solved in v1.6.1 released on 2024-02-05

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants