Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix black line appearing in some images #49
This image url request would now create a non-canonical image api request.
Could you provide some examples where you are seeing this so we could address the issue at a larger level? I'm concerned about removing canonical urls as it would not allow Level 0 consumers.
Sorry for the long wait, I was travelling. Could you explain how this would create non-canonical requests? The IIIF API allows to provide either width or height or both, even for Level 0, or did I miss something here?
Sure thing, the canonical uri syntax is described here: http://iiif.io/api/image/2.1/#canonical-uri-syntax
From that document in the
As I read this PR, it seems like it introduces size requests that have
The behavior you are describing I believe has been removed in the v2.1 image API. See: http://iiif.io/api/image/2.1/compliance/#size
cc @azaroth42 to make sure I'm reasoning correctly
I understood this as just an example, since
As for a demo showing the black line: Check the Leaflet-IIIF example page. With the lowest zoom setting, it appears below the image (at least in current Chrome and Firefox). When using tiles, it could appear right in the middle.
Thanks @tschaef . The way I understand the canonical uri is that
As far as the line goes, I think this is due to rounding implementation differences in Leaflet-IIIF and the server. It seems like using