Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement #5397 add a way to get CrT gas from string #5400

Merged
merged 2 commits into from Apr 15, 2019
Merged

Conversation

pupnewfster
Copy link
Member

@pupnewfster pupnewfster commented Apr 14, 2019

Changes proposed in this pull request:

  • Exposes getGas via the call mods.mekanism.MekanismHelper.getGas(string);
    This change is in its own class so that eventually if/when we add more types (such as making infuse type a proper type instead of a string), then we can add ways to get them in this class.

@pupnewfster pupnewfster added this to the 9.7.1 milestone Apr 14, 2019
@thiakil
Copy link
Member

thiakil commented Apr 14, 2019

I'd call it mods.mekanism.GasRegistry in CT if it were me

@thiakil thiakil merged commit bc8c4f6 into 1.12 Apr 15, 2019
@pupnewfster pupnewfster deleted the crt_utility branch April 15, 2019 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants