Skip to content

Commit 208ae09

Browse files
committed
Fix sps billboarding effect not rendering
1 parent 1a8e073 commit 208ae09

File tree

5 files changed

+6
-14
lines changed

5 files changed

+6
-14
lines changed

src/main/java/mekanism/client/render/MekanismRenderType.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ private static RenderType createStandard(String name, ResourceLocation resourceL
101101
.setTextureState(new RenderStateShard.TextureStateShard(resourceLocation, false, false))
102102
.setTransparencyState(RenderType.LIGHTNING_TRANSPARENCY)
103103
.setOutputState(RenderType.TRANSLUCENT_TARGET)
104-
.createCompositeState(true);
105-
return RenderType.create("mek_sps", DefaultVertexFormat.POSITION_TEX_COLOR, Mode.QUADS, 256, true, true, state);
104+
.createCompositeState(false);
105+
return RenderType.create("mek_sps", DefaultVertexFormat.POSITION_TEX_COLOR, Mode.QUADS, 1_536, false, true, state);
106106
});
107107
}

src/main/java/mekanism/client/render/lib/effect/BillboardingEffectRenderer.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,11 @@ private static void render(Camera camera, VertexConsumer buffer, PoseStack poseS
6060
int xIndex = tick % gridSize, yIndex = tick / gridSize;
6161
float spriteSize = 1F / gridSize;
6262
Quaternionf quaternion = camera.rotation();
63-
Vector3f[] vertexPos = {new Vector3f(-1.0F, 1.0F, 0.0F), new Vector3f(1.0F, 1.0F, 0.0F),
64-
new Vector3f(1.0F, -1.0F, 0.0F), new Vector3f(-1.0F, -1.0F, 0.0F)};
63+
Vector3f[] vertexPos = {new Vector3f(1.0F, -1.0F, 0.0F), new Vector3f(1.0F, 1.0F, 0.0F),
64+
new Vector3f(-1.0F, 1.0F, 0.0F), new Vector3f(-1.0F, -1.0F, 0.0F)};
6565
Vec3 pos = effect.getPos(partialTick).subtract(camera.getPosition());
6666
for (Vector3f vector3f : vertexPos) {
67-
quaternion.transform(vector3f);
67+
vector3f.rotate(quaternion);
6868
vector3f.mul(effect.getScale());
6969
vector3f.add((float) pos.x(), (float) pos.y(), (float) pos.z());
7070
}

src/main/java/mekanism/client/render/tileentity/RenderSPS.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import mekanism.common.util.MekanismUtils;
2424
import mekanism.common.util.MekanismUtils.ResourceType;
2525
import net.minecraft.Util;
26-
import net.minecraft.client.Minecraft;
2726
import net.minecraft.client.renderer.MultiBufferSource;
2827
import net.minecraft.client.renderer.blockentity.BlockEntityRendererProvider;
2928
import net.minecraft.core.BlockPos;
@@ -44,8 +43,6 @@ public static void clearBoltRenderers() {
4443
boltRendererMap.clear();
4544
}
4645

47-
private final Minecraft minecraft = Minecraft.getInstance();
48-
4946
public RenderSPS(BlockEntityRendererProvider.Context context) {
5047
super(context);
5148
}

src/main/resources/assets/mekanism/shaders/core/rendertype_sps.fsh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ in vec2 texCoord0;
1515
out vec4 fragColor;
1616

1717
void main() {
18-
//Merge of position_color_tex and rendertype_lightning
18+
//Merge of position_tex_color and rendertype_lightning
1919
vec4 color = texture(Sampler0, texCoord0) * vertexColor;
2020
if (color.a < 0.1) {
2121
discard;

src/main/resources/assets/mekanism/shaders/core/rendertype_sps.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
11
{
2-
"blend": {
3-
"func": "add",
4-
"srcrgb": "srcalpha",
5-
"dstrgb": "1-srcalpha"
6-
},
72
"vertex": "mekanism:rendertype_sps",
83
"fragment": "mekanism:rendertype_sps",
94
"samplers": [

0 commit comments

Comments
 (0)