Fix interacting with unformed multiblocks briefly displaying the GUI (#8089)

Author: pupnewfster

src/main/java/mekanism/common/block/BlockMekanism.java

@@ -26,7 +26,6 @@
 import net.minecraft.core.BlockPos;
 import net.minecraft.core.Direction;
 import net.minecraft.util.RandomSource;
-import net.minecraft.world.InteractionResult;
 import net.minecraft.world.ItemInteractionResult;
 import net.minecraft.world.entity.LivingEntity;
 import net.minecraft.world.entity.player.Player;
@@ -273,13 +272,6 @@ public void animateTick(@NotNull BlockState state, @NotNull Level world, @NotNul
         }
     }
 
-    protected InteractionResult genericClientActivated(BlockEntity blockEntity) {
-        if (Attribute.has(this, AttributeGui.class)) {
-            return InteractionResult.SUCCESS;
-        }
-        return InteractionResult.PASS;
-    }
-
     protected ItemInteractionResult genericClientActivated(ItemStack stack, BlockEntity blockEntity) {
         if (!Attribute.has(this, AttributeGui.class) && MekanismUtils.canUseAsWrench(stack)) {
             if (blockEntity instanceof ITileRadioactive tileRadioactive && tileRadioactive.getRadiationScale() > 0) {

src/main/java/mekanism/common/block/basic/BlockStructuralGlass.java

@@ -43,4 +43,11 @@ protected ItemInteractionResult useItemOn(@NotNull ItemStack stack, @NotNull Blo
         }
         return tile.onActivate(player, hand, stack);
     }
+
+    @NotNull
+    @Override
+    protected InteractionResult useWithoutItem(@NotNull BlockState state, @NotNull Level world, @NotNull BlockPos pos, @NotNull Player player, @NotNull BlockHitResult hit) {
+        //We handle opening the gui via useItemOn
+        return InteractionResult.PASS;
+    }
 }

src/main/java/mekanism/common/block/prefab/BlockBasicMultiblock.java

@@ -50,4 +50,11 @@ protected ItemInteractionResult useItemOn(@NotNull ItemStack stack, @NotNull Blo
         }
         return tile.onActivate(player, hand, stack);
     }
+
+    @NotNull
+    @Override
+    protected InteractionResult useWithoutItem(@NotNull BlockState state, @NotNull Level world, @NotNull BlockPos pos, @NotNull Player player, @NotNull BlockHitResult hit) {
+        //We handle opening the gui via useItemOn
+        return InteractionResult.PASS;
+    }
 }

src/main/java/mekanism/common/block/prefab/BlockTile.java

@@ -3,6 +3,7 @@
 import java.util.function.Function;
 import java.util.function.UnaryOperator;
 import mekanism.common.block.attribute.Attribute;
+import mekanism.common.block.attribute.AttributeGui;
 import mekanism.common.block.attribute.AttributeParticleFX;
 import mekanism.common.block.attribute.AttributeParticleFX.Particle;
 import mekanism.common.block.attribute.Attributes.AttributeRedstoneEmitter;
@@ -68,7 +69,7 @@ protected InteractionResult useWithoutItem(@NotNull BlockState state, @NotNull L
         if (tile == null) {
             return InteractionResult.PASS;
         } else if (world.isClientSide) {
-            return genericClientActivated(tile);
+            return Attribute.has(this, AttributeGui.class) ? InteractionResult.SUCCESS : InteractionResult.PASS;
         }
         return tile.openGui(player);
     }