Fix occasionally creating invalid tooltips that then cause crashes (#8058)

Author: pupnewfster

src/main/java/mekanism/client/gui/element/GuiDropdown.java

@@ -13,7 +13,6 @@
 import net.minecraft.client.gui.GuiGraphics;
 import net.minecraft.client.gui.components.Tooltip;
 import net.minecraft.client.gui.navigation.ScreenRectangle;
-import net.minecraft.network.chat.Component;
 import net.minecraft.resources.ResourceLocation;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
@@ -111,10 +110,7 @@ protected ScreenRectangle getTooltipRectangle(int mouseX, int mouseY) {
     public void updateTooltip(int mouseX, int mouseY) {
         int index = getHoveredIndex(mouseX, mouseY);
         if (index != -1) {
-            Tooltip text = typeTooltips.computeIfAbsent(options[index], t -> {
-                Component tooltip = t.getTooltip();
-                return tooltip == null ? null : TooltipUtils.create(tooltip);
-            });
+            Tooltip text = typeTooltips.computeIfAbsent(options[index], t -> TooltipUtils.create(t.getTooltip()));
             cachedTooltipRect = new ScreenRectangle(getX() + 1, getY() + 12 + index * 10, width - 2, 10);
             setTooltip(text);
         } else {

src/main/java/mekanism/client/gui/element/bar/GuiBar.java

@@ -1,5 +1,6 @@
 package mekanism.client.gui.element.bar;
 
+import java.util.Objects;
 import java.util.function.BooleanSupplier;
 import mekanism.client.gui.IGuiWrapper;
 import mekanism.client.gui.element.GuiTexturedElement;
@@ -84,9 +85,7 @@ void drawContentsChecked(@NotNull GuiGraphics guiGraphics, int mouseX, int mouse
     @Override
     public void updateTooltip(int mouseX, int mouseY) {
         Component tooltip = handler.getTooltip();
-        if (tooltip == null) {
-            lastTooltip = null;
-        } else if (!tooltip.equals(lastInfo)) {
+        if (!Objects.equals(tooltip, lastInfo)) {
             lastTooltip = TooltipUtils.create(tooltip);
         }
         lastInfo = tooltip;

src/main/java/mekanism/client/gui/element/button/ToggleButton.java

@@ -9,6 +9,7 @@
 import net.minecraft.network.chat.Component;
 import net.minecraft.resources.ResourceLocation;
 import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
 
 public class ToggleButton extends MekanismImageButton {
 
@@ -17,7 +18,9 @@ public class ToggleButton extends MekanismImageButton {
 
     private final ResourceLocation flipped;
     private final BooleanSupplier toggled;
+    @Nullable
     private final Tooltip yes;
+    @Nullable
     private final Tooltip no;
 
     public ToggleButton(IGuiWrapper gui, int x, int y, BooleanSupplier toggled, @NotNull IClickable onPress) {
@@ -29,12 +32,12 @@ public ToggleButton(IGuiWrapper gui, int x, int y, int size, BooleanSupplier tog
     }
 
     public ToggleButton(IGuiWrapper gui, int x, int y, int size, int textureSize, ResourceLocation toggle, ResourceLocation flipped, BooleanSupplier toggled,
-          @NotNull IClickable onPress, Component yes, Component no) {
+          @NotNull IClickable onPress, @Nullable Component yes, @Nullable Component no) {
         this(gui, x, y, size, size, textureSize, textureSize, toggle, flipped, toggled, onPress, yes, no);
     }
 
     public ToggleButton(IGuiWrapper gui, int x, int y, int width, int height, int textureWidth, int textureHeight, ResourceLocation toggle, ResourceLocation flipped,
-          BooleanSupplier toggled, @NotNull IClickable onPress, Component yes, Component no) {
+          BooleanSupplier toggled, @NotNull IClickable onPress, @Nullable Component yes, @Nullable Component no) {
         super(gui, x, y, width, height, textureWidth, textureHeight, toggle, onPress);
         this.toggled = toggled;
         this.flipped = flipped;

src/main/java/mekanism/client/gui/tooltip/TooltipUtils.java

@@ -6,6 +6,7 @@
 import mekanism.common.MekanismLang;
 import net.minecraft.client.gui.components.Tooltip;
 import net.minecraft.network.chat.Component;
+import org.jetbrains.annotations.Contract;
 import org.jetbrains.annotations.Nullable;
 
 public class TooltipUtils {
@@ -19,8 +20,12 @@ public static Tooltip create(ILangEntry langEntry) {
         return create(langEntry.translate());
     }
 
-    public static Tooltip create(Component messages) {
-        Tooltip tooltip = Tooltip.create(messages);
+    @Contract("null -> null")
+    public static Tooltip create(@Nullable Component message) {
+        if (message == null) {
+            return null;
+        }
+        Tooltip tooltip = Tooltip.create(message);
         //Set the delay to -1 so that it appears immediately instead of after a single millisecond
         tooltip.setDelay(-1);
         return tooltip;