Validate that the module config sent by the client is valid

Author: pupnewfster

src/api/java/mekanism/api/gear/config/ModuleConfig.java

@@ -41,6 +41,8 @@ public final String name() {
 
     public abstract DATA get();
 
+    //throws null pointer if value is null
+    //throws IllegalArgumentException if value is not valid
     public abstract ModuleConfig<DATA> with(DATA value);
 
     public boolean isConfigDisabled() {

src/datagen/generated/mekanism/.cache/59eb3dbb5f86130e09b3c62d89b9525ee01cf52d

@@ -836,6 +836,7 @@ private void addMisc() {
         add(MekanismLang.LOG_FORMAT, "[%1$s] %2$s");
         add(MekanismLang.FORGE, "NeoForge");
         add(MekanismLang.ERROR, "Error");
+        add(MekanismLang.INVALID_PACKET, "Invalid packet data received: %1$s");
         add(MekanismLang.ALPHA_WARNING, "Warning: " + modName + " is currently in alpha, and is not recommended for widespread use in modpacks. There are likely to be game breaking bugs, and various other issues that you can read more about %1$s.");
         add(MekanismLang.ALPHA_WARNING_HERE, "here");
         //Equipment

src/datagen/generated/mekanism/.cache/c10fcd8abbb6a520fc3ac2cf14b627d36958dd55

@@ -22,6 +22,7 @@ public enum MekanismLang implements ILangEntry {
     PACK_DESCRIPTION("constants", "pack_description"),
     FORGE("constants", "forge"),
     ERROR("constants", "error"),
+    INVALID_PACKET("constants", "error.packet.invalid"),
     ALPHA_WARNING("constants", "alpha_warning"),
     ALPHA_WARNING_HERE("constants", "alpha_warning.here"),
     //Equipment

src/datagen/generated/mekanism/assets/mekanism/lang/en_ud.json

@@ -225,12 +225,28 @@ Module<MODULE> withReplacedInstallCount(HolderLookup.Provider provider, int inst
     }
 
     Module<MODULE> withReplacedConfig(ModuleConfig<?> config) {
+        return withReplacedConfig(config, false);
+    }
+
+    //throws IllegalArgumentException
+    //throws IllegalStateException
+    <CONFIG> Module<MODULE> withReplacedConfig(ModuleConfig<CONFIG> config, boolean fromPacket) {
         for (int i = 0; i < configItems.size(); i++) {
             ModuleConfig<?> storedConfig = configItems.get(i);
             if (storedConfig.name().equals(config.name())) {
                 if (storedConfig.get().equals(config.get())) {
                     //Nothing changed
                     return this;
+                } else if (fromPacket) {
+                    //Note: This cast is theoretically not unsafe as when reading from the packet we validate
+                    // that the type is what we expect it to be. To be safe though we double-check the classes
+                    if (storedConfig.getClass() != config.getClass()) {
+                        //Invalid, don't apply the change
+                        throw new IllegalStateException("Config " + config.name() + "'s Class " + config.getClass().getSimpleName() + "  did not match " + storedConfig.getClass().getSimpleName());
+                    }
+                    //Ensure we sanitize it and that it actually has the correct range applied and the client
+                    // didn't just lie about how many are installed in order to get a higher value set
+                    config = ((ModuleConfig<CONFIG>) storedConfig).with(config.get());
                 }
                 List<ModuleConfig<?>> copiedConfigs = new ArrayList<>(configItems);
                 copiedConfigs.set(i, config);

src/datagen/generated/mekanism/assets/mekanism/lang/en_us.json

@@ -104,8 +104,15 @@ public List<Component> getHUDStrings(Player player, ItemStack stack) {
         return ret;
     }
 
+    //throws IllegalStateException
     @Override
     public <MODULE extends ICustomModule<MODULE>> ModuleContainer replaceModuleConfig(ItemStack stack, ModuleData<MODULE> type, ModuleConfig<?> config) {
+        return replaceModuleConfig(stack, type, config, false);
+    }
+
+    //throws IllegalArgumentException
+    //throws IllegalStateException
+    public <MODULE extends ICustomModule<MODULE>> ModuleContainer replaceModuleConfig(ItemStack stack, ModuleData<MODULE> type, ModuleConfig<?> config, boolean fromPacket) {
         Module<MODULE> module = get(type);
         if (module == null) {
             throw new IllegalArgumentException("Module container does not contain any modules of type " + type.getRegistryName());
@@ -119,12 +126,15 @@ public <MODULE extends ICustomModule<MODULE>> ModuleContainer replaceModuleConfi
         } else if (config.name().equals(ModuleConfig.HANDLES_MODE_CHANGE_KEY)) {
             if (module.handlesModeChangeRaw() == (boolean) config.get()) {
                 return this;//State matches no change needed
+            } else if (fromPacket && module.getConfig(ModuleConfig.HANDLES_MODE_CHANGE_KEY) == null) {
+                //Illegal state, got a packet for mode change key, but it doesn't support mode changes
+                return this;
             }
             //Toggle the handle mode state including any side effects changing that config may have
             return toggleHandlesModeChange(stack, type, module);
         }
 
-        Module<MODULE> replacedModule = module.withReplacedConfig(config);
+        Module<MODULE> replacedModule = module.withReplacedConfig(config, fromPacket);
         if (module == replacedModule) {
             //If nothing actually changed we don't need to bother updating the instance on the stack
             return this;