Cleanup fall damage reduction logic:

 - Make fall protection take new safe fall distance attribute into account
 - Account for the damage multiplier of the block and the entity
 - Fixed handling when the remaining energy would only partially protect from the damage
 - Allow step sound handling to make use of combination step sounds for players

Author: pupnewfster

src/main/java/mekanism/common/CommonPlayerTickHandler.java

@@ -59,11 +59,6 @@
 
 public class CommonPlayerTickHandler {
 
-    /**
-     * From {@link LivingEntity#calculateFallDamage(float, float)}, distance above this amount causes fall damage
-     */
-    private static final float MIN_FALL_HURT = 3.0F;
-
     public static boolean isOnGroundOrSleeping(Player player) {
         return player.onGround() || player.isSleeping() || player.getAbilities().flying;
     }
@@ -215,13 +210,22 @@ public void onEntityAttacked(LivingIncomingDamageEvent event) {
         }
     }
 
+    /**
+     * Based on the values and calculations that happen in {@link LivingEntity#calculateFallDamage(float, float)}
+     */
     @SubscribeEvent
     public void livingFall(LivingFallEvent event) {
-        float fallDamage = Math.max(event.getDistance() - MIN_FALL_HURT, 0);
-        if (fallDamage <= Mth.EPSILON) {
+        LivingEntity entity = event.getEntity();
+        float safeFallDistance = (float) entity.getAttributeValue(Attributes.SAFE_FALL_DISTANCE);
+        float fallDistance = Math.max(event.getDistance() - safeFallDistance, 0);
+        if (fallDistance <= Mth.EPSILON) {
+            return;
+        }
+        double damageMultiplier = event.getDamageMultiplier() * entity.getAttributeValue(Attributes.FALL_DAMAGE_MULTIPLIER);
+        int fallDamage = Mth.ceil(fallDistance * damageMultiplier);
+        if (fallDamage <= 0) {//This may be the case for things like slime blocks that have a damage multiplier of zero
             return;
         }
-        LivingEntity entity = event.getEntity();
         FallEnergyInfo info = getFallAbsorptionEnergyInfo(entity);
         if (info != null && info.container != null) {
             float absorption = info.damageRatio.getAsFloat();
@@ -233,16 +237,25 @@ public void livingFall(LivingFallEvent event) {
                 // or how small the amount to absorb is
                 ratioAbsorbed = absorption;
             } else {
-                ratioAbsorbed = absorption * info.container.extract(energyRequirement, Action.EXECUTE, AutomationType.MANUAL).divide(amount).floatValue();
+                FloatingLong extracted = info.container.extract(energyRequirement, Action.EXECUTE, AutomationType.MANUAL);
+                ratioAbsorbed = absorption * extracted.divide(energyRequirement).floatValue();
             }
             if (ratioAbsorbed > 0) {
                 float damageRemaining = fallDamage * Math.max(0, 1 - ratioAbsorbed);
                 if (damageRemaining <= Mth.EPSILON) {
                     event.setCanceled(true);
-                    SoundType soundtype = entity.getBlockStateOn().getSoundType(entity.level(), entity.getOnPos(), entity);
-                    entity.playSound(soundtype.getStepSound(), soundtype.getVolume() * 0.15F, soundtype.getPitch());
+                    BlockPos posOn = entity.getOnPos();
+                    BlockState stateOn = entity.level().getBlockState(posOn);
+                    if (entity instanceof Player player) {
+                        player.playStepSound(posOn, stateOn);
+                    } else {
+                        //Fallback to default implementation
+                        SoundType soundtype = stateOn.getSoundType(entity.level(), posOn, entity);
+                        entity.playSound(soundtype.getStepSound(), soundtype.getVolume() * 0.15F, soundtype.getPitch());
+                    }
                 } else {
-                    event.setDistance(damageRemaining + MIN_FALL_HURT);
+                    float distanceRemaining = (float) (damageRemaining / damageMultiplier);
+                    event.setDistance(distanceRemaining + safeFallDistance);
                 }
             }
         }

src/main/resources/META-INF/accesstransformer.cfg

@@ -92,6 +92,7 @@ public net.minecraft.world.entity.LivingEntity effectsDirty
 public net.minecraft.world.entity.LivingEntity refreshDirtyAttributes()V
 public net.minecraft.world.entity.LivingEntity hurtCurrentlyUsedShield(F)V
 public net.minecraft.world.entity.player.Player hurtCurrentlyUsedShield(F)V
+public net.minecraft.world.entity.player.Player playStepSound(Lnet/minecraft/core/BlockPos;Lnet/minecraft/world/level/block/state/BlockState;)V
 public net.minecraft.world.entity.item.ItemEntity age
 public net.minecraft.world.entity.Entity setLevel(Lnet/minecraft/world/level/Level;)V