Fix deferred tooltip rendering in GUIs not obeying the z offset (#8120)

Author: pupnewfster

src/main/java/mekanism/client/gui/GuiMekanism.java

@@ -53,6 +53,7 @@ public abstract class GuiMekanism<CONTAINER extends AbstractContainerMenu> exten
     public static final ResourceLocation BASE_BACKGROUND = MekanismUtils.getResource(ResourceType.GUI, "base.png");
     public static final ResourceLocation SHADOW = MekanismUtils.getResource(ResourceType.GUI, "shadow.png");
     public static final ResourceLocation BLUR = MekanismUtils.getResource(ResourceType.GUI, "blur.png");
+    private static final int EXTRA_Z_OFFSET = -500;
     //TODO: Look into defaulting this to true
     protected boolean dynamicSlots;
     protected boolean initialFocusSet;
@@ -323,7 +324,6 @@ record PreviousElement(int index, GuiElement element, boolean wasFocus) {
 
     @Override
     protected void renderLabels(@NotNull GuiGraphics guiGraphics, int mouseX, int mouseY) {
-        //PoseStack modelViewStack = RenderSystem.getModelViewStack();
         //Note: We intentionally don't push the modelViewStack, see notes further down in this method for more details
         //TODO - 1.20: Figure this out as some transforms and hacks may be unnecessary now
         PoseStack pose = guiGraphics.pose();
@@ -379,14 +379,11 @@ protected void renderLabels(@NotNull GuiGraphics guiGraphics, int mouseX, int mo
         //TODO - 1.20: Can we remove these transforms that are around the tooltip rendering
         // No, we maybe could remove from the tooltip element portion but definitely not from the stack rendering/parent renderTooltip method
         pose.translate(-leftPos, -topPos, 0);
-        //modelViewStack.translate(-leftPos, -topPos, 0);
-        //RenderSystem.applyModelViewMatrix();
         if (tooltipElement != null) {
             tooltipElement.renderToolTip(guiGraphics, mouseX, mouseY);
         }
         renderTooltip(guiGraphics, mouseX, mouseY);
         pose.translate(leftPos, topPos, 0);
-        //modelViewStack.translate(leftPos, topPos, 0);
 
         // IMPORTANT: additional hacky translation so held items render okay. re-evaluate as discussed above
         // Note: It is important that we don't wrap our adjustments to the modelViewStack in so that we can
@@ -395,6 +392,23 @@ protected void renderLabels(@NotNull GuiGraphics guiGraphics, int mouseX, int mo
         pose.translate(0, 0, 200);
     }
 
+    /**
+     * @implNote Copy of super, but adjusts the z value for tooltip rendering
+     */
+    @Override
+    public final void renderWithTooltip(@NotNull GuiGraphics graphics, int mouseX, int mouseY, float partialTick) {
+        render(graphics, mouseX, mouseY, partialTick);
+        if (deferredTooltipRendering != null) {
+            PoseStack pose = graphics.pose();
+            pose.pushPose();
+            //Note: extra z offset comes from the offset we do in render
+            pose.translate(0, 0, EXTRA_Z_OFFSET + maxZOffset);
+            graphics.renderTooltip(font, deferredTooltipRendering.tooltip(), deferredTooltipRendering.positioner(), mouseX, mouseY);
+            clearTooltipForNextRenderPass();
+            pose.popPose();
+        }
+    }
+
     protected void drawForegroundText(@NotNull GuiGraphics guiGraphics, int mouseX, int mouseY) {
     }
 
@@ -684,7 +698,7 @@ public void render(@NotNull GuiGraphics guiGraphics, int mouseX, int mouseY, flo
         pose.pushPose();
         // shift back a whole lot so we can stack more windows
         //TODO - 1.20: Validate this, used to translate the modelViewStack
-        pose.translate(0, 0, -500);
+        pose.translate(0, 0, EXTRA_Z_OFFSET);
         super.render(guiGraphics, mouseX, mouseY, partialTicks);
         pose.popPose();
     }

src/main/java/mekanism/client/gui/element/text/GuiTextField.java

@@ -203,6 +203,7 @@ public boolean mouseClicked(double mouseX, double mouseY, int button) {
 
     //TODO - 1.21: Figure out why Guis with text fields seem to still have issues with https://github.com/emilyploszaj/emi/issues/480 when other ones don't
     // and it doesn't seem related to any of the code inside this draw background block
+    // There is also an issue if enough gui windows are open, where EMI then renders the tooltip behind the third crafting window, which might be related
     @Override
     public void drawBackground(@NotNull GuiGraphics guiGraphics, int mouseX, int mouseY, float partialTicks) {
         super.drawBackground(guiGraphics, mouseX, mouseY, partialTicks);

src/main/resources/META-INF/accesstransformer.cfg

@@ -39,6 +39,11 @@ protected net.minecraft.client.gui.screens.inventory.AbstractContainerScreen isH
 protected net.minecraft.client.gui.screens.inventory.AbstractContainerScreen renderSlot(Lnet/minecraft/client/gui/GuiGraphics;Lnet/minecraft/world/inventory/Slot;)V
 protected net.minecraft.client.gui.screens.inventory.AbstractContainerScreen checkHotbarMouseClicked(I)V
 
+# Used to fix the z level of tooltip rendering
+public net.minecraft.client.gui.screens.Screen$DeferredTooltipRendering
+public net.minecraft.client.gui.screens.Screen deferredTooltipRendering
+public-f net.minecraft.client.gui.screens.Screen renderWithTooltip(Lnet/minecraft/client/gui/GuiGraphics;IIF)V
+
 public net.minecraft.client.model.AgeableListModel scaleHead
 public net.minecraft.client.model.AgeableListModel babyHeadScale
 public net.minecraft.client.model.AgeableListModel babyBodyScale