Skip to content

Commit e7dde77

Browse files
committed
add constant for array creation
1 parent cba0bec commit e7dde77

File tree

4 files changed

+10
-5
lines changed

4 files changed

+10
-5
lines changed

src/generators/java/mekanism/generators/common/tile/TileEntityAdvancedSolarGenerator.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
public class TileEntityAdvancedSolarGenerator extends TileEntitySolarGenerator implements IBoundingBlock, IEvaporationSolar {
1717

18+
private static final RelativeSide[] ENERGY_SIDES = {RelativeSide.FRONT, RelativeSide.BOTTOM};
1819
private final SolarCheck[] solarChecks = new SolarCheck[8];
1920

2021
public TileEntityAdvancedSolarGenerator(BlockPos pos, BlockState state) {
@@ -23,7 +24,7 @@ public TileEntityAdvancedSolarGenerator(BlockPos pos, BlockState state) {
2324

2425
@Override
2526
protected RelativeSide[] getEnergySides() {
26-
return new RelativeSide[]{RelativeSide.FRONT, RelativeSide.BOTTOM};
27+
return ENERGY_SIDES;
2728
}
2829

2930
@Override

src/generators/java/mekanism/generators/common/tile/TileEntityGenerator.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@
2626

2727
public abstract class TileEntityGenerator extends TileEntityMekanism {
2828

29+
private static final RelativeSide[] ENERGY_SIDES = {RelativeSide.FRONT};
30+
2931
@Nullable
3032
private List<BlockEnergyCapabilityCache> outputCaches;
3133
/**
@@ -43,7 +45,7 @@ public TileEntityGenerator(IBlockProvider blockProvider, BlockPos pos, BlockStat
4345
}
4446

4547
protected RelativeSide[] getEnergySides() {
46-
return new RelativeSide[]{RelativeSide.FRONT};
48+
return ENERGY_SIDES;
4749
}
4850

4951
@NotNull
@@ -63,7 +65,7 @@ protected boolean onUpdateServer() {
6365
Direction direction = getDirection();
6466
RelativeSide[] energySides = getEnergySides();
6567
outputCaches = new ArrayList<>(energySides.length);
66-
for (RelativeSide energySide : getEnergySides()) {
68+
for (RelativeSide energySide : energySides) {
6769
Direction side = energySide.getDirection(direction);
6870
outputCaches.add(BlockEnergyCapabilityCache.create((ServerLevel) level, worldPosition.relative(side), side.getOpposite()));
6971
}

src/generators/java/mekanism/generators/common/tile/TileEntitySolarGenerator.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929

3030
public class TileEntitySolarGenerator extends TileEntityGenerator {
3131

32+
private static final RelativeSide[] ENERGY_SIDES = {RelativeSide.BOTTOM};
3233
private boolean seesSun;
3334
private FloatingLong lastProductionAmount = FloatingLong.ZERO;
3435
@WrappingComputerMethod(wrapper = ComputerIInventorySlotWrapper.class, methodNames = "getEnergyItem", docPlaceholder = "energy item slot")
@@ -114,7 +115,7 @@ protected float getBrightnessMultiplier(@NotNull Level world) {
114115

115116
@Override
116117
protected RelativeSide[] getEnergySides() {
117-
return new RelativeSide[]{RelativeSide.BOTTOM};
118+
return ENERGY_SIDES;
118119
}
119120

120121
protected FloatingLong getConfiguredMax() {

src/generators/java/mekanism/generators/common/tile/TileEntityWindGenerator.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
public class TileEntityWindGenerator extends TileEntityGenerator implements IBoundingBlock {
2828

2929
private static final float SPEED = 32F;
30+
private static final RelativeSide[] ENERGY_SIDES = {RelativeSide.FRONT, RelativeSide.BOTTOM};
3031

3132
private double angle;
3233
private FloatingLong currentMultiplier = FloatingLong.ZERO;
@@ -48,7 +49,7 @@ protected IInventorySlotHolder getInitialInventory(IContentsListener listener) {
4849

4950
@Override
5051
protected RelativeSide[] getEnergySides() {
51-
return new RelativeSide[]{RelativeSide.FRONT, RelativeSide.BOTTOM};
52+
return ENERGY_SIDES;
5253
}
5354

5455
@Override

0 commit comments

Comments
 (0)