Add a couple helper methods to ConnectionType to make it slightly clearer in places what is going on logically

Author: pupnewfster

src/main/java/mekanism/common/content/network/transmitter/LogisticalTransporterBase.java

@@ -72,8 +72,7 @@ public boolean handlesRedstone() {
     }
 
     public boolean exposesInsertCap(@NotNull Direction side) {
-        ConnectionType connectionType = getConnectionTypeRaw(side);
-        return connectionType == ConnectionType.NORMAL || connectionType == ConnectionType.PULL;
+        return getConnectionTypeRaw(side).canAccept();
     }
 
     @Nullable
@@ -82,19 +81,11 @@ public EnumColor getColor() {
     }
 
     public boolean canEmitTo(Direction side) {
-        if (canConnect(side)) {
-            ConnectionType connectionType = getConnectionType(side);
-            return connectionType == ConnectionType.NORMAL || connectionType == ConnectionType.PUSH;
-        }
-        return false;
+        return canConnect(side) && getConnectionType(side).canSendTo();
     }
 
     public boolean canReceiveFrom(Direction side) {
-        if (canConnect(side)) {
-            ConnectionType connectionType = getConnectionType(side);
-            return connectionType == ConnectionType.NORMAL || connectionType == ConnectionType.PULL;
-        }
-        return false;
+        return canConnect(side) && getConnectionType(side).canAccept();
     }
 
     @Override
@@ -221,7 +212,7 @@ public void onUpdateServer() {
                             if (pathType == Path.DEST || pathType == Path.HOME) {
                                 Direction side = stack.getSide(this);
                                 ConnectionType connectionType = getConnectionType(side);
-                                tryRecalculate = connectionType != ConnectionType.NORMAL && connectionType != ConnectionType.PUSH ||
+                                tryRecalculate = !connectionType.canSendTo() ||
                                                  !TransporterUtils.canInsert(getLevel(), stack.getDest(), stack.color, stack.itemStack, side, pathType == Path.HOME);
                             } else {
                                 tryRecalculate = pathType == Path.NONE;
@@ -233,7 +224,7 @@ public void onUpdateServer() {
                                 // in a single length transmitter, in which case we only recalculate it at 50 if it won't
                                 // be able to go into that connection type
                                 ConnectionType connectionType = getConnectionType(stack.getSide(this));
-                                tryRecalculate = connectionType != ConnectionType.NORMAL && connectionType != ConnectionType.PUSH;
+                                tryRecalculate = !connectionType.canSendTo();
                             } else {
                                 tryRecalculate = !stack.canInsertToTransporter(nextTransmitter, stack.getSide(this), this);
                             }

src/main/java/mekanism/common/content/network/transmitter/Transmitter.java

@@ -350,8 +350,7 @@ public boolean isValidTransmitterBasic(TileEntityTransmitter transmitter, Direct
     }
 
     public boolean canConnectToAcceptor(Direction side) {
-        ConnectionType type = getConnectionTypeRaw(side);
-        return type == ConnectionType.NORMAL || type == ConnectionType.PUSH;
+        return getConnectionTypeRaw(side).canSendTo();
     }
 
     /**

src/main/java/mekanism/common/lib/transmitter/ConnectionType.java

@@ -51,4 +51,18 @@ public ConnectionType byIndex(int index) {
     public static ConnectionType byIndexStatic(int index) {
         return MathUtils.getByIndexMod(TYPES, index);
     }
+
+    /**
+     * @return {@code true} If this connection type allows other things to insert into it.
+     */
+    public boolean canAccept() {
+        return this == NORMAL || this == PULL;
+    }
+
+    /**
+     * @return {@code true} If this connection type can send to other things or allow them to extract from it.
+     */
+    public boolean canSendTo() {
+        return this == NORMAL || this == PUSH;
+    }
 }

src/main/java/mekanism/common/tile/transmitter/TileEntityTransmitter.java

@@ -418,8 +418,7 @@ public void redstoneChanged(boolean powered) {
                 return true;
             }
             //If we have a side only allow extracting if our connection allows it
-            ConnectionType connectionType = getTransmitter().getConnectionType(side);
-            return connectionType == ConnectionType.NORMAL || connectionType == ConnectionType.PUSH;
+            return getTransmitter().getConnectionType(side).canSendTo();
         };
     }
 
@@ -430,8 +429,7 @@ public void redstoneChanged(boolean powered) {
                 return true;
             }
             //If we have a side only allow inserting if our connection allows it
-            ConnectionType connectionType = getTransmitter().getConnectionType(side);
-            return connectionType == ConnectionType.NORMAL || connectionType == ConnectionType.PULL;
+            return getTransmitter().getConnectionType(side).canAccept();
         };
     }
 }