Skip to content

Conversation

pupnewfster
Copy link
Member

@pupnewfster pupnewfster commented Apr 6, 2024

Changes proposed in this pull request:

  • Makes Structural glass and reactor glass no longer be Ticking BEs
  • Improves handling of structural blocks when they have multiple structures (still shouldn't be any cases this is a thing for yet)
  • Improve handling so that placing structural blocks next to formed multiblocks is better at not causing them to reform

* Returns true if the multiblock's gui can be accessed via structural multiblocks, false otherwise. An example this may be false for would be on a thermal
* evaporation plant.
*/
public boolean allowsStructuralGuiAccess(TileEntityStructuralMultiblock multiblock) {

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'multiblock' is never used.
@pupnewfster pupnewfster marked this pull request as ready for review April 6, 2024 18:20
@pupnewfster pupnewfster added this to the 10.5.18 milestone Apr 6, 2024
@pupnewfster pupnewfster requested a review from thiakil April 6, 2024 18:20
@pupnewfster pupnewfster force-pushed the nonticking_structural branch from 45d40dd to 707069f Compare April 7, 2024 14:36
@pupnewfster pupnewfster merged commit e1b05e9 into 1.20.4 Apr 9, 2024
@pupnewfster pupnewfster deleted the nonticking_structural branch April 9, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants