Remove 'name' attribute from relationship type #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mks-d
reviewed
Dec 22, 2021
| @@ -29,7 +29,6 @@ public void load_shouldLoadRelationshipTypesAccordingToCsvFiles() { | |||
| { | |||
| RelationshipType rt = ps.getRelationshipTypeByUuid("c86d9979-b8ac-4d8c-85cf-cc04e7f16315"); | |||
| Assert.assertNotNull(rt); | |||
| Assert.assertEquals("Uncle/Nephew", rt.getName()); | |||
There was a problem hiding this comment.
the "name" attribute of relationship types isn't actually stored in the database
@mogoodrich / @brandones how come such asserts (that you have suggested to remove) would have worked until now then?
If you look at the test above, it's fetching a relationship type by UUID and that fetched relationship type does carry a name...
There was a problem hiding this comment.
I would guess that that's an artifact of the test environment. Or something related to the Hibernate cache. It is easy enough to verify that the database model has no name attribute: https://github.com/openmrs/openmrs-core/blob/master/api/src/main/resources/org/openmrs/api/db/hibernate/RelationshipType.hbm.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mogoodrich pointed out that the "name" attribute of relationship types isn't actually stored in the database.
Attn @mks-d